Skip to content

Commit 925f157

Browse files
Make JavaOptionsEqualsTest and JavaOptionsTest work when external fake runtime is used
1 parent 8de450d commit 925f157

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

test/jdk/tools/jpackage/share/JavaOptionsEqualsTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,13 @@ public static Collection<?> input() {
7575
}
7676

7777
public JavaOptionsEqualsTest(String javaAppDesc, String[] jpackageArgs) {
78-
cmd = JPackageCommand.helloAppImage(javaAppDesc);
79-
if (jpackageArgs != null) {
80-
cmd.addArguments(jpackageArgs);
81-
}
78+
cmd = JPackageCommand.helloAppImage(javaAppDesc).addArguments(jpackageArgs).ignoreFakeRuntime();
8279
}
8380

8481
@Test
8582
public void test() {
8683
cmd.executeAndAssertHelloAppImageCreated();
8784
List<String> output = HelloApp.executeLauncher(cmd).getOutput();
88-
TKit.assertNotNull(output, "output is null");
8985
TKit.assertTextStream(WARNING1).apply(output.stream());
9086
TKit.assertTextStream(WARNING2).apply(output.stream());
9187
}

test/jdk/tools/jpackage/share/JavaOptionsTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public static Collection<?> input() {
7676

7777
public JavaOptionsTest(String javaAppDesc, String[] jpackageArgs,
7878
String[] expectedParams) {
79-
cmd = JPackageCommand.helloAppImage(javaAppDesc);
79+
cmd = JPackageCommand.helloAppImage(javaAppDesc).ignoreFakeRuntime();
8080
if (jpackageArgs != null) {
8181
cmd.addArguments(jpackageArgs);
8282
}
@@ -90,7 +90,6 @@ public void test() {
9090

9191
// 2.) run the launcher it generated
9292
List<String> output = HelloApp.executeLauncher(cmd).getOutput();
93-
TKit.assertNotNull(output, "output is null");
9493
for (String expect : expected) {
9594
TKit.assertTextStream(expect).apply(output.stream());
9695
}

0 commit comments

Comments
 (0)