Skip to content

Commit 9477c42

Browse files
committed
8356276: JavaScript error in script.js after JDK-8348282
Reviewed-by: liach
1 parent 088825e commit 9477c42

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Head.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ private void addStylesheets(HtmlTree head) {
352352

353353
if (syntaxHighlight) {
354354
addStylesheet(head, DocPaths.RESOURCE_FILES.resolve(DocPaths.HIGHLIGHT_CSS));
355-
addScriptElement(head, DocPaths.HIGHLIGHT_JS);
356355
}
357356

358357
for (DocPath path : localStylesheets) {
@@ -367,6 +366,9 @@ private void addStylesheet(HtmlTree head, DocPath stylesheet) {
367366
}
368367

369368
private void addScripts(HtmlTree head) {
369+
if (syntaxHighlight) {
370+
addScriptElement(head, DocPaths.HIGHLIGHT_JS);
371+
}
370372
if (addDefaultScript) {
371373
addScriptElement(head, DocPaths.SCRIPT_JS);
372374
}

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script.js.template

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,12 @@ var activeTableTab = "active-table-tab";
2121
const linkIcon = "##REPLACE:doclet.Link_icon##";
2222
const linkToSection = "##REPLACE:doclet.Link_to_section##";
2323

24-
if (hljs) {
25-
hljs.highlightAll();
24+
if (typeof hljs !== "undefined") {
25+
try {
26+
hljs.highlightAll();
27+
} catch (err) {
28+
console.error(err)
29+
}
2630
}
2731

2832
function loadScripts(doc, tag) {

0 commit comments

Comments
 (0)