Skip to content

Commit fd08005

Browse files
Fix service description
1 parent 775605e commit fd08005

File tree

6 files changed

+22
-11
lines changed

6 files changed

+22
-11
lines changed

src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxLaunchersAsServices.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public static Path getServiceUnitFileName(String packageName, String launcherNam
7373
private static final class LauncherImpl extends UnixLauncherAsService {
7474

7575
LauncherImpl(BuildEnv env, Package pkg, Launcher launcher) {
76-
super(launcher, env.createResource("unit-template.service").setCategory(
76+
super(pkg.app(), launcher, env.createResource("unit-template.service").setCategory(
7777
I18N.getString("resource.systemd-unit-file")));
7878

7979
unitFilename = getServiceUnitFileName(pkg.packageName(), launcher.executableName());

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacLaunchersAsServices.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public static Path getServicePListFileName(String bundleIdentifier,
5050
private static class MacLauncherAsService extends UnixLauncherAsService {
5151

5252
MacLauncherAsService(BuildEnv env, MacPackage pkg, Launcher launcher) {
53-
super(launcher, env.createResource("launchd.plist.template").setCategory(I18N
53+
super(pkg.app(), launcher, env.createResource("launchd.plist.template").setCategory(I18N
5454
.getString("resource.launchd-plist-file")));
5555

5656
plistFilename = getServicePListFileName(pkg.app().bundleIdentifier(), getName());

src/jdk.jpackage/share/classes/jdk/jpackage/internal/LauncherAsService.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,24 @@
2424
*/
2525
package jdk.jpackage.internal;
2626

27+
import java.util.Objects;
28+
import jdk.jpackage.internal.model.Application;
2729
import jdk.jpackage.internal.model.Launcher;
2830

2931
class LauncherAsService {
3032

31-
LauncherAsService(Launcher launcher, OverridableResource resource) {
33+
LauncherAsService(Application app, Launcher launcher, OverridableResource resource) {
3234
this.name = launcher.name();
33-
this.description = launcher.description();
34-
this.resource = resource;
35+
36+
if (app.mainLauncher().orElseThrow() == launcher) {
37+
// Main launcher
38+
this.description = launcher.description();
39+
} else {
40+
// Additional launcher
41+
this.description = String.format("%s (%s)", app.description(), name);
42+
}
43+
44+
this.resource = Objects.requireNonNull(resource);
3545
resource.addSubstitutionDataEntry("SERVICE_DESCRIPTION", description);
3646
}
3747

src/jdk.jpackage/unix/classes/jdk/jpackage/internal/UnixLaunchersAsServices.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ boolean isEmpty() {
103103

104104
abstract static class UnixLauncherAsService extends LauncherAsService {
105105

106-
UnixLauncherAsService(Launcher launcher, OverridableResource resource) {
107-
super(launcher, resource);
106+
UnixLauncherAsService(Application app, Launcher launcher, OverridableResource resource) {
107+
super(app, launcher, resource);
108108
}
109109

110110
abstract Path descriptorFilePath(Path root);

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixAppImageFragmentBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ void initFromParams(BuildEnv env, WinMsiPackage pkg) {
107107
var launcherPath = installedAppImage.launchersDirectory().resolve(
108108
launcher.executableNameWithSuffix());
109109
var id = Id.File.of(launcherPath);
110-
return new WixLauncherAsService(launcher, env::createResource)
110+
return new WixLauncherAsService(pkg.app(), launcher, env::createResource)
111111
.setLauncherInstallPath(toWixPath(launcherPath))
112112
.setLauncherInstallPathId(id);
113113
}).toList();

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixLauncherAsService.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
*/
2525
package jdk.jpackage.internal;
2626

27-
import jdk.jpackage.internal.model.WinLauncher;
2827
import java.io.ByteArrayInputStream;
2928
import java.io.ByteArrayOutputStream;
3029
import java.io.IOException;
@@ -39,6 +38,8 @@
3938
import javax.xml.xpath.XPathConstants;
4039
import javax.xml.xpath.XPathExpressionException;
4140
import javax.xml.xpath.XPathFactory;
41+
import jdk.jpackage.internal.model.WinApplication;
42+
import jdk.jpackage.internal.model.WinLauncher;
4243
import jdk.jpackage.internal.util.XmlUtils;
4344
import org.w3c.dom.Document;
4445
import org.w3c.dom.Node;
@@ -47,8 +48,8 @@
4748

4849
class WixLauncherAsService extends LauncherAsService {
4950

50-
WixLauncherAsService(WinLauncher launcher, Function<String, OverridableResource> createResource) {
51-
super(launcher,
51+
WixLauncherAsService(WinApplication app, WinLauncher launcher, Function<String, OverridableResource> createResource) {
52+
super(app, launcher,
5253
createResource.apply("service-install.wxi").setCategory(
5354
I18N.getString("resource.launcher-as-service-wix-file")));
5455

0 commit comments

Comments
 (0)