Skip to content

Commit 7b4875b

Browse files
authored
fix(installer): separate skill and agent counts in summary (bmad-code-org#1932)
Subtract agents from total skill directories so the summary shows non-agent skills and agents as distinct counts (e.g. 34 skills, 10 agents) instead of double-counting agents in the skill total.
1 parent c575064 commit 7b4875b

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

test/test-installation-components.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1846,7 +1846,7 @@ async function runTests() {
18461846
});
18471847

18481848
assert(result.success === true, 'Antigravity setup succeeds with overlapping skill names');
1849-
assert(result.detail === '2 skills, 2 agents', 'Installer detail reports total skills and total agents');
1849+
assert(result.detail === '2 agents', 'Installer detail reports agents separately from skills');
18501850
assert(result.handlerResult.results.skillDirectories === 2, 'Result exposes unique skill directory count');
18511851
assert(result.handlerResult.results.agents === 2, 'Result retains generated agent write count');
18521852
assert(result.handlerResult.results.workflows === 1, 'Result retains generated workflow count');

tools/cli/installers/lib/ide/_config-driven.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -712,9 +712,10 @@ LOAD and execute from: {project-root}/{{bmadFolderName}}/{{path}}
712712
async printSummary(results, targetDir, options = {}) {
713713
if (options.silent) return;
714714
const parts = [];
715-
const totalSkills =
715+
const totalDirs =
716716
results.skillDirectories || (results.workflows || 0) + (results.tasks || 0) + (results.tools || 0) + (results.skills || 0);
717-
if (totalSkills > 0) parts.push(`${totalSkills} skills`);
717+
const skillCount = totalDirs - (results.agents || 0);
718+
if (skillCount > 0) parts.push(`${skillCount} skills`);
718719
if (results.agents > 0) parts.push(`${results.agents} agents`);
719720
await prompts.log.success(`${this.name} configured: ${parts.join(', ')}${targetDir}`);
720721
}

tools/cli/installers/lib/ide/manager.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,9 @@ class IdeManager {
162162
// Config-driven handlers return { success, results: { agents, workflows, tasks, tools } }
163163
const r = handlerResult.results;
164164
const parts = [];
165-
const totalSkills = r.skillDirectories || (r.workflows || 0) + (r.tasks || 0) + (r.tools || 0) + (r.skills || 0);
166-
if (totalSkills > 0) parts.push(`${totalSkills} skills`);
165+
const totalDirs = r.skillDirectories || (r.workflows || 0) + (r.tasks || 0) + (r.tools || 0) + (r.skills || 0);
166+
const skillCount = totalDirs - (r.agents || 0);
167+
if (skillCount > 0) parts.push(`${skillCount} skills`);
167168
if (r.agents > 0) parts.push(`${r.agents} agents`);
168169
detail = parts.join(', ');
169170
}

0 commit comments

Comments
 (0)