Skip to content

Restore coloring for NA values #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexhallam wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Restore coloring for NA values #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tidy-viewer-cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ mod datatype;

// Import from inline modules (formerly tidy_viewer_core)
use crate::datatype::{
format_strings, get_col_data_type, is_na, is_negative_number,
format_strings, get_col_data_type, is_na, is_na_string_padded, is_negative_number,
parse_delimiter,
};

Expand Down Expand Up @@ -1179,7 +1179,7 @@ fn main() {
}

// title
if !is_na(&title_option.clone()) {
if !is_na_string_padded(&title_option.clone()) {
let _ = match stdout!("{: >6} ", "") {
Ok(_) => Ok(()),
Err(e) => match e.kind() {
Expand Down Expand Up @@ -1317,7 +1317,7 @@ fn main() {
if is_tty || is_force_color {
let _ = match stdout!(
"{}",
if is_na(col) {
if is_na_string_padded(col) {
col.truecolor(na_color[0], na_color[1], na_color[2])
} else if is_negative_number(col) {
col.truecolor(neg_num_color[0], neg_num_color[1], neg_num_color[2])
Expand Down Expand Up @@ -1466,7 +1466,7 @@ fn main() {
}

// footer
if !is_na(&footer_option.clone()) {
if !is_na_string_padded(&footer_option.clone()) {
let _ = match stdout!("{: >6} ", "") {
Ok(_) => Ok(()),
Err(e) => match e.kind() {
Expand Down