Unexpected error in the Snap package

[aitva]

Hello,

Thank you for publishing Go tools in the Snap store, I noticed today and tried golangci-lint. But, I get an unexpected error that point to the Snap package. Before opening the ticket, I tried the following configurations:

• I have installed the package with and without the --classic option
• I have updated my local installation to match the version from the store
• I have tried on multiple modules (with and without cgo)
• I have tried with the Go compiler installed as a Snap package
• I have tried with the Go compiler installed under /usr/local/go

The error is always there and it is always the same. Here are the commands I used:

$ golangci-lint version
golangci-lint has version 1.49.0 built from cc2d97f3 on 2022-08-24T10:24:37Z
$ golangci-lint run
$ /snap/bin/golangci-lint version
golangci-lint has version 1.49.0 built from cc2d97f3 on 2022-08-24T12:18:21Z
$ /snap/bin/golangci-lint run .
../../../../../snap/golangci-lint/94/src/runtime/cgo/cgo.go:34:8: could not import C (cgo preprocessing failed) (typecheck)
import "C"
       ^

[alexmurray]

Thanks for reporting this issue - I am not able to reproduce it myself though so I am wondering if you can please try and provide some more info.

What path is your go project? The snap only has access to files under $HOME so if it is not there then it is not expected to work.

Also the snap doesn't even have access to the host's go compiler so that should not matter - instead it ships the go compiler from the go snap inside itself and uses that.

Perhaps you have some environment variable set locally that is causing this issue. Can you post the output of env?

[aitva]

My projects are store under $HOME/dev so it should not be the issue. Moreover, the Snap version of golangci-lint does work, I tried introducing invalid statements and they were reported as expected. But the could not import C error is always there. 🤔

Here is the output of the env command:

$ env
SHELL=/bin/bash
SESSION_MANAGER=local/louis-XPS-9320:@/tmp/.ICE-unix/1519,unix/louis-XPS-9320:/tmp/.ICE-unix/1519
QT_ACCESSIBILITY=1
COLORTERM=truecolor
XDG_CONFIG_DIRS=/etc/xdg/xdg-ubuntu:/etc/xdg
SSH_AGENT_LAUNCHER=gnome-keyring
XDG_MENU_PREFIX=gnome-
TERM_PROGRAM_VERSION=3.2a
GNOME_DESKTOP_SESSION_ID=this-is-deprecated
TMUX=/tmp/tmux-1000/default,13523,0
LC_ADDRESS=fr_FR.UTF-8
GNOME_SHELL_SESSION_MODE=ubuntu
LC_NAME=fr_FR.UTF-8
SSH_AUTH_SOCK=/run/user/1000/keyring/ssh
GOPRIVATE=github.com/aitva/*
XMODIFIERS=@im=ibus
DESKTOP_SESSION=ubuntu
LC_MONETARY=fr_FR.UTF-8
EDITOR=vim
GTK_MODULES=gail:atk-bridge
API_DB_HOST=localhost
PWD=/home/louis
XDG_SESSION_DESKTOP=ubuntu
LOGNAME=louis
XDG_SESSION_TYPE=wayland
SYSTEMD_EXEC_PID=1854
XAUTHORITY=/run/user/1000/.mutter-Xwaylandauth.LBXBR1
IM_CONFIG_CHECK_ENV=1
HOME=/home/louis
USERNAME=louis
IM_CONFIG_PHASE=1
LC_PAPER=fr_FR.UTF-8
LANG=en_US.UTF-8
LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.webp=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:
XDG_CURRENT_DESKTOP=ubuntu:GNOME
VTE_VERSION=6800
WAYLAND_DISPLAY=wayland-0
GNOME_TERMINAL_SCREEN=/org/gnome/Terminal/screen/ebd1a61d_8550_48e7_9079_319cbf9f954d
GNOME_SETUP_DISPLAY=:1
LESSCLOSE=/usr/bin/lesspipe %s %s
XDG_SESSION_CLASS=user
TERM=screen-256color
LC_IDENTIFICATION=fr_FR.UTF-8
LESSOPEN=| /usr/bin/lesspipe %s
USER=louis
TMUX_PANE=%0
GNOME_TERMINAL_SERVICE=:1.1873
VISUAL=vim
DISPLAY=:0
SHLVL=2
LC_TELEPHONE=fr_FR.UTF-8
QT_IM_MODULE=ibus
LC_MEASUREMENT=fr_FR.UTF-8
XDG_RUNTIME_DIR=/run/user/1000
REPORT_DEBUG=1
LC_TIME=fr_FR.UTF-8
XDG_DATA_DIRS=/usr/share/ubuntu:/usr/local/share/:/usr/share/:/var/lib/snapd/desktop
PATH=/home/louis/go/bin:/home/louis/.bin:/home/louis/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin
GDMSESSION=ubuntu
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
BOT_DEBUG=1
LC_NUMERIC=fr_FR.UTF-8
GOPATH=/home/louis/go
TERM_PROGRAM=tmux
_=/usr/bin/env

[alexmurray]

Thanks - does this happen with all projects? Can you give me an example of a particular project so I can try and reproduce this error?

[aitva]

I can reproduce the problem on all my projects and also some Open Source projects I have locally. Below are the steps to reproduce for Caddy:

git clone https://github.com/caddyserver/caddy.git
cd caddy
find . -type f -name "*.go" -exec gofmt -s -w {} \; # remove gofmt errors
go build ./...

The local linter produces a few warnings and returns successfully :

$ golangci-lint run ./...
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.

The snap linter produces a lot of errors and fails:

$ /snap/bin/golangci-lint run ./...
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.
listeners.go:328:2: undeclared name: `quic` (typecheck)
        quic.EarlyListener
        ^
listeners.go:92:75: undeclared name: `quic` (typecheck)
func ListenQUIC(addr string, tlsConf *tls.Config, activeRequests *int64) (quic.EarlyListener, error) {
                                                                          ^
listeners.go:206:63: undeclared name: `quic` (typecheck)
func (fcql *fakeCloseQuicListener) Accept(_ context.Context) (quic.EarlyConnection, error) {
                                                              ^
caddy.go:450:24: invalid operation: cannot compare newCfg.storage == nil (operator == not defined on untyped nil) (typecheck)
                if newCfg.storage == nil {
                                     ^
listeners.go:148:34: fcl.sharedListener.Accept undefined (type *sharedListener has no field or method Accept) (typecheck)
        conn, err := fcl.sharedListener.Accept()
                                        ^
listeners.go:207:39: fcql.sharedQuicListener.Accept undefined (type *sharedQuicListener has no field or method Accept) (typecheck)
        conn, err := fcql.sharedQuicListener.Accept(fcql.context)
                                             ^
listeners.go:292:8: previous case (typecheck)
                case *net.TCPListener:
                     ^
listeners.go:309:8: previous case (typecheck)
                case *net.TCPListener:
                     ^
listeners.go:24:2: "os" imported but not used (typecheck)
        "os"
        ^
listeners.go:32:2: "github.com/lucas-clemente/quic-go" imported but not used (typecheck)
        "github.com/lucas-clemente/quic-go"
        ^
caddyconfig/httploader.go:46:10: undeclared name: `caddy` (typecheck)
        Timeout caddy.Duration `json:"timeout,omitempty"`
                ^
caddyconfig/configadapters.go:131:39: undeclared name: `caddy` (typecheck)
func (am adapterModule) CaddyModule() caddy.ModuleInfo {
                                      ^
caddyconfig/httploader.go:65:33: undeclared name: `caddy` (typecheck)
func (HTTPLoader) CaddyModule() caddy.ModuleInfo {
                                ^
caddyconfig/configadapters.go:21:2: "github.com/caddyserver/caddy/v2" imported but not used (typecheck)
        "github.com/caddyserver/caddy/v2"
        ^
caddyconfig/httploader.go:26:2: "github.com/caddyserver/caddy/v2" imported but not used (typecheck)
        "github.com/caddyserver/caddy/v2"
        ^
caddyconfig/load.go:27:2: "github.com/caddyserver/caddy/v2" imported but not used (typecheck)
        "github.com/caddyserver/caddy/v2"
        ^
modules/caddypki/ca.go:108:19: invalid operation: cannot compare ca.storage == nil (operator == not defined on untyped nil) (typecheck)
        if ca.storage == nil {
                         ^
modules/caddytls/tls.go:491:21: invalid operation: cannot compare ap.storage == nil (operator == not defined on untyped nil) (typecheck)
                        if ap.storage == nil {
                                         ^
modules/caddytls/acmeissuer.go:31:2: "github.com/mholt/acmez" imported but not used (typecheck)
        "github.com/mholt/acmez"
        ^
modules/caddyhttp/autohttps.go:132:29: invalid operation: cannot compare srv.TLSConnPolicies == nil (operator == not defined on untyped nil) (typecheck)
                if srv.TLSConnPolicies == nil &&
                                          ^
modules/caddyhttp/autohttps.go:215:29: invalid operation: cannot compare srv.TLSConnPolicies == nil (operator == not defined on untyped nil) (typecheck)
                if srv.TLSConnPolicies == nil {
                                          ^
modules/caddyhttp/celmatcher.go:206:17: celReq.Context undefined (type celHTTPRequest has no field or method Context) (typecheck)
        repl := celReq.Context().Value(caddy.ReplacerCtxKey).(*caddy.Replacer)
                       ^
modules/caddyhttp/marshalers.go:35:39: r.RemoteAddr undefined (type LoggableHTTPRequest has no field or method RemoteAddr) (typecheck)
        ip, port, err := net.SplitHostPort(r.RemoteAddr)
                                             ^
modules/caddyhttp/marshalers.go:37:10: r.RemoteAddr undefined (type LoggableHTTPRequest has no field or method RemoteAddr) (typecheck)
                ip = r.RemoteAddr
                       ^
modules/caddyhttp/marshalers.go:43:27: r.Proto undefined (type LoggableHTTPRequest has no field or method Proto) (typecheck)
        enc.AddString("proto", r.Proto)
                                 ^
modules/caddyhttp/marshalers.go:44:28: r.Method undefined (type LoggableHTTPRequest has no field or method Method) (typecheck)
        enc.AddString("method", r.Method)
                                  ^
modules/caddyhttp/marshalers.go:45:26: r.Host undefined (type LoggableHTTPRequest has no field or method Host) (typecheck)
        enc.AddString("host", r.Host)
                                ^
modules/caddyhttp/marshalers.go:46:25: r.RequestURI undefined (type LoggableHTTPRequest has no field or method RequestURI) (typecheck)
        enc.AddString("uri", r.RequestURI)
                               ^
modules/caddyhttp/marshalers.go:48:27: r.Header undefined (type LoggableHTTPRequest has no field or method Header) (typecheck)
                Header:               r.Header,
                                        ^
modules/caddyhttp/marshalers.go:51:7: r.TLS undefined (type LoggableHTTPRequest has no field or method TLS) (typecheck)
        if r.TLS != nil {
             ^
modules/caddyhttp/marshalers.go:52:48: r.TLS undefined (type LoggableHTTPRequest has no field or method TLS) (typecheck)
                enc.AddObject("tls", LoggableTLSConnState(*r.TLS))
                                                             ^
modules/caddyhttp/marshalers.go:68:17: invalid operation: cannot compare h.Header == nil (operator == not defined on untyped nil) (typecheck)
        if h.Header == nil {
                       ^
modules/caddyhttp/matchers.go:851:5: invalid operation: cannot compare *m == nil (mismatched types MatchHeader and untyped nil) (typecheck)
        if *m == nil {
           ^
modules/caddyhttp/matchers.go:852:8: cannot use make(map[string][]string) (value of type map[string][]string) as MatchHeader value in assignment (typecheck)
                *m = make(map[string][]string)
                     ^
modules/caddyhttp/matchers.go:867:4: invalid operation: cannot index headers (variable of type MatchHeader) (typecheck)
                        headers[field] = nil
                        ^
modules/caddyhttp/responsematchers.go:81:27: invalid operation: cannot compare matcher.Headers == nil (operator == not defined on untyped nil) (typecheck)
                                if matcher.Headers == nil {
                                                      ^
modules/caddyhttp/responsewriter.go:162:72: rr.ResponseWriterWrapper.Header undefined (type *ResponseWriterWrapper has no field or method Header) (typecheck)
                rr.stream = !rr.shouldBuffer(rr.statusCode, rr.ResponseWriterWrapper.Header())
                                                                                     ^
modules/caddyhttp/responsewriter.go:167:28: rr.ResponseWriterWrapper.WriteHeader undefined (type *ResponseWriterWrapper has no field or method WriteHeader) (typecheck)
                rr.ResponseWriterWrapper.WriteHeader(rr.statusCode)
                                         ^
modules/caddyhttp/responsewriter.go:176:37: rr.ResponseWriterWrapper.Write undefined (type *ResponseWriterWrapper has no field or method Write) (typecheck)
                n, err = rr.ResponseWriterWrapper.Write(data)
                                                  ^
modules/caddyhttp/responsewriter.go:217:27: rr.ResponseWriterWrapper.WriteHeader undefined (type *ResponseWriterWrapper has no field or method WriteHeader) (typecheck)
        rr.ResponseWriterWrapper.WriteHeader(rr.statusCode)
                                 ^
modules/caddyhttp/responsewriter.go:218:20: cannot use rr.ResponseWriterWrapper (variable of type *ResponseWriterWrapper) as io.Writer value in argument to io.Copy: *ResponseWriterWrapper does not implement io.Writer (missing method Write) (typecheck)
        _, err := io.Copy(rr.ResponseWriterWrapper, rr.buf)
                          ^
modules/caddyhttp/server.go:243:33: wrec.Header undefined (type ResponseRecorder has no field or method Header) (typecheck)
                                        Header:               wrec.Header(),
                                                                   ^
modules/caddyhttp/vars.go:19:2: "fmt" imported but not used (typecheck)
        "fmt"
        ^
caddyconfig/httpcaddyfile/builtins.go:58:8: h.Next undefined (type Helper has no field or method Next) (typecheck)
        for h.Next() {
              ^
caddyconfig/httpcaddyfile/builtins.go:59:31: h.RemainingArgs undefined (type Helper has no field or method RemainingArgs) (typecheck)
                lnHosts = append(lnHosts, h.RemainingArgs()...)
                                            ^
caddyconfig/httpcaddyfile/builtins.go:99:8: h.Next undefined (type Helper has no field or method Next) (typecheck)
        for h.Next() {
              ^
caddyconfig/httpcaddyfile/builtins.go:101:18: h.RemainingArgs undefined (type Helper has no field or method RemainingArgs) (typecheck)
                firstLine := h.RemainingArgs()
                               ^
caddyconfig/httpcaddyfile/builtins.go:108:19: h.Err undefined (type Helper has no field or method Err) (typecheck)
                                return nil, h.Err("single argument must either be 'internal' or an email address")
                                              ^
caddyconfig/httpcaddyfile/builtins.go:162:18: h.ArgErr undefined (type Helper has no field or method ArgErr) (typecheck)
                        return nil, h.ArgErr()
                                      ^
caddyconfig/httpcaddyfile/builtins.go:166:20: h.Nesting undefined (type Helper has no field or method Nesting) (typecheck)
                for nesting := h.Nesting(); h.NextBlock(nesting); {
                                 ^