Upgrade dependencies, 1st step

Author: alexrecuenco

.eslintrc.js

@@ -23,19 +23,16 @@ module.exports = {
   plugins: ['@typescript-eslint/eslint-plugin'],
   parser: '@typescript-eslint/parser',
   parserOptions: {
-    ecmaVersion: 2020, // Allows for the parsing of modern ECMAScript features
-    sourceType: 'module', // Allows for the use of imports
+    ecmaVersion: 2022,
+    sourceType: 'module',
     tsconfigRootDir: __dirname,
     project: ['./tsconfig.eslint.json'],
   },
   rules: {
     'import/no-extraneous-dependencies': warn,
-
-    // Temporal?
-    'no-console': warn,
-    'no-return-await': warn,
+    'no-console': error,
     'no-unused-vars': off,
-    '@typescript-eslint/no-unused-vars': off,
+    '@typescript-eslint/no-unused-vars': error,
     eqeqeq: [error, 'smart'],
     'no-else-return': [
       error,
@@ -59,7 +56,6 @@ module.exports = {
       },
     ],
     camelcase: off,
-    '@typescript-eslint/camelcase': off,
     'require-await': off,
     '@typescript-eslint/require-await': off,
     '@typescript-eslint/indent': off,
@@ -71,7 +67,6 @@ module.exports = {
     '@typescript-eslint/explicit-function-return-type': off,
     '@typescript-eslint/no-var-requires': off,
     '@typescript-eslint/no-empty-function': off,
-    '@typescript-eslint/no-object-literal-type-assertion': off,
     '@typescript-eslint/no-floating-promises': error,
   },
   overrides: [
@@ -90,7 +85,10 @@ module.exports = {
         'tests/**/*.ts',
         '__tests__/**/*.js',
         '__tests__/**/*.ts',
-        'jest.setup.js',
+        'jest.*.js',
+        'jest.*.ts',
+        '.*.ts',
+        '.*.js',
       ],
 
       // https://eslint.org/docs/user-guide/configuring#specifying-environments
@@ -99,15 +97,16 @@ module.exports = {
       },
 
       // Can't extend in overrides: https://github.com/eslint/eslint/issues/8813
-      // "extends": ["plugin:jest/recommended"]
+      extends: ['plugin:jest/recommended'],
       plugins: ['jest'],
       rules: {
         'no-restricted-imports': off,
-        'jest/no-disabled-tests': warn,
-        'jest/no-focused-tests': error,
-        'jest/no-identical-title': error,
-        'jest/prefer-to-have-length': warn,
-        'jest/valid-expect': error,
+        'jest/expect-expect': [
+          error,
+          {
+            assertFunctionNames: ['expect', 'fc.assert'],
+          },
+        ],
       },
     },
   ],

.pre-commit-config.yaml

@@ -19,7 +19,3 @@ repos: #The order matters, we want prospector to run after all the sorting was d
       # File normalization
       - id: end-of-file-fixer
       - id: trailing-whitespace
-  - repo: https://github.com/prettier/prettier
-    rev: '6b22977cb56127cc10e04425b0eca7c5eb304e6e' # Use the sha or tag you want to point at
-    hooks:
-      - id: prettier

.prettierrc.js

@@ -1,4 +1,5 @@
-/** @type {import("@types/prettier").Options} */
+//@ts-check
+/** @type {import("prettier").Options} */
 const options = {
   semi: true,
   trailingComma: 'all',

.vscode/extensions.json

@@ -1,7 +1,6 @@
 {
     "recommendations": [
         "dbaeumer.vscode-eslint",
-        "esbenp.prettier-vscode",
         "ghmcadams.lintlens",
         "visualstudioexptteam.vscodeintellicode",
         "wix.vscode-import-cost",

.vscode/settings.json

@@ -1,8 +1,15 @@
 {
-    "eslint.validate": ["typescript", "typescriptreact"],
+    "eslint.validate": [
+        "typescript",
+        "typescriptreact"
+    ],
     "editor.formatOnSave": true,
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
+    "editor.defaultFormatter": "dbaeumer.vscode-eslint",
     "[javascript]": {
-        "editor.defaultFormatter": "esbenp.prettier-vscode"
+        "editor.defaultFormatter": "dbaeumer.vscode-eslint"
+    },
+    "jest.jestCommandLine": "npm test -- ",
+    "jest.runMode": {
+        "type": "on-demand"
     }
 }

README.md

@@ -5,3 +5,10 @@ Example of typescript, eslint, and jest with property based testing.
 Possibly, you might want to delete the `.pre-commit-config.yaml` file if you are not using python anywhere.
 
 This is only tested with certain versions of node and npm, it might work with others, disable the `engine-strict=true` in the `.npmrc` file at your discretion.
+
+
+## Check upgrades
+
+```bash
+npx npm-check -u
+```

jest.config.js renamed to jest.config.ts

@@ -1,6 +1,6 @@
-//@ts-check
-/** @type {Partial<import("@jest/types").Config.InitialOptions>} */
-const config = {
+import type { JestConfigWithTsJest } from 'ts-jest';
+
+const config: JestConfigWithTsJest = {
   preset: 'ts-jest',
   testRegex: ['/tests/.*tests?.[jt]sx?', '/__tests__/.*tests?.[jt]sx?', '.*.(spec|test).[jt]sx?'],
   // I dono't think we need to run the spec multiple times.. the functional test on tests/ maybe.
@@ -11,7 +11,7 @@ const config = {
   verbose: true,
   // Important to use the AfterEnv to have the jest timeout and all the other settings inside that file to be correctly understood
   // See the difference between setupFiles and setupFilesAfterEnv to see the difference.
-  setupFilesAfterEnv: ['./jest.setup.js'],
+  setupFilesAfterEnv: ['./jest.setup.ts'],
 };
 
 module.exports = config;

jest.setup.js renamed to jest.setup.ts

@@ -3,7 +3,7 @@
  *  https://github.com/dubzzz/fast-check/blob/1ceb2b982b754b99aef8d763723206605b67451e/example/jest.setup.js
  */
 
-const fc = require('fast-check');
+import fc from 'fast-check';
 
 // Default timeout of 60s
 const JestTimeoutMs = 60000;
@@ -13,8 +13,8 @@ const verbose =
   process.env.DEBUG === undefined
     ? fc.VerbosityLevel.None
     : process.env.DEBUG !== '*'
-    ? fc.VerbosityLevel.Verbose
-    : fc.VerbosityLevel.VeryVerbose;
+      ? fc.VerbosityLevel.Verbose
+      : fc.VerbosityLevel.VeryVerbose;
 
 jest.setTimeout(JestTimeoutMs);
 fc.configureGlobal({