Commit f895b19
Add ATSC golden path guide with reusable InfoBanner component and E2E tests (#238)
* Initial plan
* Add ATSC golden path guide and UX improvements
- Create comprehensive ATSC Golden Path Guide tutorial
- Add prominent links to golden path in README and docs
- Update Help page with golden path quick start section
- Add context banners to ATSCPlayer, Scanner, and EPG components
- Label Analysis page as advanced feature
- Enhance navigation tooltips with clear descriptions
- Update ROADMAP to emphasize golden path workflow
- Fix linting and test issues
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
* Refactor banners to use reusable InfoBanner component with design tokens
- Create InfoBanner component with info/advanced variants
- Add design tokens for banner colors (--rad-info-*, --rad-advanced-*)
- Replace hardcoded banners in ATSCPlayer, Scanner, EPG, Analysis, Help
- Fix accessibility: consistent role="status" for dynamic banners, role="note" for static
- Add comprehensive unit tests for InfoBanner (9/9 passing)
- All linting, formatting, and tests passing
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
* Add comprehensive E2E test for ATSC golden path workflow
- Create e2e/atsc-golden-path.spec.ts with 11 test cases
- Verify context banners appear in appropriate states
- Test keyboard navigation shortcuts (2, 6, ?)
- Verify accessibility attributes (role, aria-live)
- Check design token usage in InfoBanner
- Validate enhanced navigation tooltips
- Document complete golden path workflow for regression testing
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
* Refactor InfoBanner to use CSS classes instead of inline styles
- Create src/styles/components/info-banner.css with reusable styles
- Update InfoBanner component to use CSS classes for all styling
- Replace inline styles in ATSCPlayer, Scanner, EPG, Analysis, Help pages
- Add CSS classes: info-banner__paragraph, info-banner__footer, info-banner__list
- Improve maintainability by consolidating styles in CSS file
- Link colors and text decorations now handled by CSS
- All tests passing, linting clean, build successful
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
* Fix PR review feedback: accessibility, light theme, and CSS naming
- Add role="status" to Scanner and EPG InfoBanners (conditionally displayed)
- Add light theme tokens for InfoBanner colors in tokens.css
- Replace inline styles in Analysis and Help with CSS classes
- Convert CSS class names from BEM to kebab-case for stylelint compliance
- Update all component usages and tests to use kebab-case classes
- All linting, tests, and build passing
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
* Eliminate all inline styles and add missing text colors
- Add CSS utility classes for margins and padding (.info-banner-margin-top, .info-banner-compact, etc.)
- Add text color rules for paragraph, list, and footer elements in both variants
- Replace all inline styles with CSS classes in ATSCPlayer, Scanner, EPG, Analysis, Help
- Add role="status" to ATSCPlayer banner for accessibility consistency
- Remove Analysis-specific fontSize inline style (unique requirement remains)
- All linting, tests, and build passing
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
* Remove final inline style with CSS utility class
- Add .info-banner-footer-small CSS class (13px font size)
- Replace fontSize inline style in Analysis with CSS class
- Achieve complete elimination of all inline styles
- All linting and build passing
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
* Fix Navigation test to match updated tooltip text
- Update test expectations to match enhanced navigation tooltips
- Monitor: now includes "Start here for general SDR use"
- Scanner: now includes "Essential for finding signals"
- Analysis: now includes "Advanced feature"
- All tests passing
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexthemitchell <5687158+alexthemitchell@users.noreply.github.com>
Co-authored-by: Alex Mitchell <alex+github@alexmitchelltech.com>1 parent ad70945 commit f895b19
File tree
19 files changed
+1399
-12
lines changed- docs
- tutorials
- e2e
- src
- components
- EPG
- __tests__
- pages
- __tests__
- styles
- components
19 files changed
+1399
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
8 | 25 | | |
9 | 26 | | |
10 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
3 | 20 | | |
4 | 21 | | |
5 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
5 | 15 | | |
6 | 16 | | |
7 | 17 | | |
| |||
0 commit comments