Fix tests

Author: alexthemitchell

src/hooks/__tests__/useMultiVfoProcessor.test.ts

@@ -115,6 +115,11 @@ describe("useMultiVfoProcessor", () => {
         });
       }
 
+      // Wait for async VFO initialization
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 100));
+      });
+
       // Process samples
       await act(async () => {
         await result.current.processSamples(samples);
@@ -180,6 +185,11 @@ describe("useMultiVfoProcessor", () => {
         });
       }
 
+      // Wait for async VFO initialization
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 100));
+      });
+
       // Process samples
       await act(async () => {
         await result.current.processSamples(samples);
@@ -267,6 +277,11 @@ describe("useMultiVfoProcessor", () => {
         samples.push({ I: Math.random(), Q: Math.random() });
       }
 
+      // Wait for async VFO initialization
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 100));
+      });
+
       // Process samples
       await act(async () => {
         await result.current.processSamples(samples);
@@ -279,8 +294,8 @@ describe("useMultiVfoProcessor", () => {
         const disabledVfo = vfos.find((v) => !v.audioEnabled);
 
         expect(enabledVfo?.metrics?.samplesProcessed).toBeGreaterThan(0);
-        // Disabled VFO should not have metrics updated
-        expect(disabledVfo?.metrics).toBeUndefined();
+        // Disabled VFO should not have metrics updated (or remain at initial 0)
+        expect(disabledVfo?.metrics?.samplesProcessed).toBe(0);
       });
     });
   });

src/hooks/useMultiVfoProcessor.ts

@@ -204,7 +204,7 @@ export function useMultiVfoProcessor(options: UseMultiVfoProcessorOptions): {
     };
 
     void initializeVfos();
-  }, [vfos, getAllVfos]); // Re-run when VFO map changes
+  }, [vfos]); // Re-run when VFO map changes
 
   /**
    * Process IQ samples through all active VFOs

src/pages/Monitor.tsx

@@ -39,6 +39,7 @@ import {
   useDiagnostics,
   useSignalLevel,
   useVfo,
+  useStore,
 } from "../store";
 // import { shouldUseMockSDR } from "../utils/e2e";
 import { updateBulkCachedRDSData } from "../store/rdsCache";
@@ -201,8 +202,12 @@ const Monitor: React.FC = () => {
       }
 
       // Route samples to multi-VFO processor
-      // The processSamples function handles empty VFO checks internally
-      if (vfoProcessor.isReady) {
+      // Check for active VFOs directly from store to avoid stale closures
+      const vfos = useStore.getState().getAllVfos();
+      const hasActiveVfos = vfos.some((v) => v.audioEnabled);
+
+      if (hasActiveVfos) {
+        // processSamples handles initialization checks internally via refs
         vfoProcessor.processSamples(samples).catch((error: unknown) => {
           console.error("VFO processing error:", error);
         });

src/utils/webAudioUtils.ts

@@ -97,12 +97,12 @@ export function createAudioBufferFromSamples(
     const rightChannel = new Float32Array(numFrames);
 
     // Deinterleave stereo samples (numFrames guaranteed <= samples.length / 2)
-    // TypeScript requires ?? 0 due to noUncheckedIndexedAccess: true in tsconfig.json
+    // Use non-null assertion (!) as bounds are guaranteed by numFrames calculation
     for (let i = 0; i < numFrames; i++) {
       const leftIdx = i * 2;
       const rightIdx = i * 2 + 1;
-      leftChannel[i] = samples[leftIdx] ?? 0;
-      rightChannel[i] = samples[rightIdx] ?? 0;
+      leftChannel[i] = samples[leftIdx]!;
+      rightChannel[i] = samples[rightIdx]!;
     }
 
     buffer.copyToChannel(leftChannel, 0);
@@ -133,16 +133,16 @@ export function mixAudioBuffers(buffers: Float32Array[]): Float32Array {
     const len = Math.min(buffer.length, mixed.length);
     for (let i = 0; i < len; i++) {
       // Float32Array elements are initialized to 0 and accessed within bounds
-      // ?? 0 required due to noUncheckedIndexedAccess: true in tsconfig.json
-      mixed[i] = (mixed[i] ?? 0) + (buffer[i] ?? 0);
+      // Use non-null assertion (!) as bounds are guaranteed by len calculation
+      mixed[i] = mixed[i]! + buffer[i]!;
     }
   }
 
   // Normalize by buffer count to prevent clipping
   const scale = 1 / buffers.length;
   for (let i = 0; i < mixed.length; i++) {
-    // ?? 0 required due to noUncheckedIndexedAccess: true in tsconfig.json
-    mixed[i] = (mixed[i] ?? 0) * scale;
+    // Use non-null assertion (!) as bounds are guaranteed by loop condition
+    mixed[i] = mixed[i]! * scale;
   }
 
   return mixed;