tests pass

Author: alexwox

run_tests.sh

@@ -3,23 +3,23 @@
 # Run unit tests by default
 if [ "$1" == "--all" ]; then
     echo "Running all tests..."
-    python -m pytest
+    python3 -m pytest
 elif [ "$1" == "--integration" ]; then
     echo "Running integration tests..."
-    python -m pytest -m "integration"
+    python3 -m pytest -m "integration"
 elif [ "$1" == "--coverage" ]; then
     echo "Running tests with coverage report..."
-    python -m pytest --cov=src --cov-report=term-missing
+    python3 -m pytest --cov=src --cov-report=term-missing
 elif [ "$1" == "--models" ]; then
     echo "Running model tests only..."
-    python -m pytest tests/test_models.py tests/test_model_validation.py
+    python3 -m pytest tests/test_models.py tests/test_model_validation.py
 elif [ "$1" == "--edge-cases" ]; then
     echo "Running edge case tests only..."
-    python -m pytest tests/test_edge_cases.py
+    python3 -m pytest tests/test_edge_cases.py
 elif [ "$1" == "--performance" ]; then
     echo "Running performance tests..."
     python -m pytest -m "performance"
 else
     echo "Running unit tests only..."
-    python -m pytest -m "not integration and not performance"
+    python3 -m pytest -m "not integration and not performance"
 fi 

src/borsdata_client/client.py

@@ -70,12 +70,14 @@ def _get(self, endpoint: str, params: Optional[Dict[str, Any]] = None) -> Dict[s
 
         try:
             response = self._client.get(f"{self.BASE_URL}{endpoint}", params=params)
-            response.raise_for_status()
+            response.raise_for_status()  # This will raise an HTTPError for 4XX/5XX responses
             return response.json()
-        except httpx.HTTPError as e:
-            raise BorsdataClientError(f"HTTP request failed: {str(e)}") from e
-        except ValueError as e:
-            raise BorsdataClientError(f"Failed to parse JSON response: {str(e)}") from e
+        except httpx.HTTPStatusError as e:
+            error_msg = str(e)
+            status_code = e.response.status_code
+            raise BorsdataClientError(f"API request failed with status code {status_code}: {error_msg}") from e
+        except Exception as e:
+            raise BorsdataClientError(f"API request failed: {str(e)}") from e
 
     def get_branches(self) -> List[Branch]:
         """Get all branches/industries.

tests/conftest.py

@@ -44,8 +44,28 @@ def mock_get(self, endpoint: str, params: Dict[str, Any] = None) -> Dict[str, An
             with open(fixture_path, 'r') as f:
                 return json.load(f)
         else:
-            # If no fixture file exists, return an empty response
-            return {}
+            # If no fixture file exists, return an appropriate empty response
+            # based on the endpoint
+            if endpoint == "/instruments/kpis/metadata":
+                return {"kpiHistoryMetadatas": []}
+            elif endpoint.startswith("/holdings/insider"):
+                return {"list": []}
+            elif endpoint.startswith("/holdings/shorts"):
+                return {"list": []}
+            elif endpoint.startswith("/holdings/buyback"):
+                return {"list": []}
+            elif endpoint.startswith("/instruments/description"):
+                return {"list": []}
+            elif endpoint.startswith("/instruments/report/calendar"):
+                return {"list": []}
+            elif endpoint.startswith("/instruments/dividend/calendar"):
+                return {"list": []}
+            elif endpoint.startswith("/instruments/stockprices/date") or endpoint.startswith("/instruments/stockprices/global/date"):
+                return {"values": []}
+            elif endpoint == "/translationmetadata":
+                return {"branches": [], "sectors": [], "countries": []}
+            else:
+                return {}
 
     # Replace the _get method with our mock
     monkeypatch.setattr(client, '_get', mock_get.__get__(client))

tests/fixtures/holdings_buyback.json

@@ -0,0 +1 @@
+{"list": [{"insId": 1, "values": [{"change": 1000, "changeProc": 0.01, "price": 100.0, "currency": "SEK", "shares": 10000, "sharesProc": 0.05, "date": "2023-01-01T12:00:00"}], "error": null}]}

tests/fixtures/holdings_insider.json

@@ -0,0 +1 @@
+{"list": [{"insId": 1, "values": [{"misc": false, "ownerName": "Test Owner", "ownerPosition": "CEO", "equityProgram": false, "shares": 10000, "price": 100.0, "amount": 1000000.0, "currency": "SEK", "transactionType": 1, "verificationDate": "2023-01-01T12:00:00", "transactionDate": "2023-01-01T10:00:00"}], "error": null}]}

tests/fixtures/holdings_shorts.json

@@ -0,0 +1 @@
+{"list": [{"insId": 1, "values": [{"positionHolder": "Test Holder", "position": 0.5, "date": "2023-01-01T12:00:00"}], "error": null}]}

tests/fixtures/instruments_description.json

@@ -0,0 +1 @@
+{"list": [{"insId": 1, "languageCode": "en", "text": "Test description", "error": null}]}

tests/fixtures/instruments_dividend_calendar.json

@@ -0,0 +1 @@
+{"list": [{"insId": 1, "values": [{"amountPaid": 1.5, "currencyShortName": "SEK", "distributionFrequency": 1, "excludingDate": "2023-04-15T00:00:00", "dividendType": 1}], "error": null}]}

tests/fixtures/instruments_kpis_metadata.json

@@ -1 +1 @@
-{"kpiMetadatas": [{"kpiId": 1, "nameSv": "KPI 1 (SV)", "nameEn": "KPI 1 (EN)", "format": "0.00", "isString": false}, {"kpiId": 2, "nameSv": "KPI 2 (SV)", "nameEn": "KPI 2 (EN)", "format": "0.00%", "isString": false}]}
+{"kpiHistoryMetadatas": [{"kpiId": 1, "nameSv": "KPI 1 (SV)", "nameEn": "KPI 1 (EN)", "format": "0.00", "isString": false}, {"kpiId": 2, "nameSv": "KPI 2 (SV)", "nameEn": "KPI 2 (EN)", "format": "0.00%", "isString": false}]}

tests/fixtures/instruments_report_calendar.json

@@ -0,0 +1 @@
+{"list": [{"insId": 1, "values": [{"releaseDate": "2023-04-01T08:00:00", "reportType": "Q1"}], "error": null}]}