v4.9.1 fixes #144

Author: Lars-Erik Roald

dist/index.browser.mjs

@@ -4132,8 +4132,10 @@ function requireNewShallowJoinSqlCore () {
 
 	function _new(context, rightTable, leftColumns, rightColumns, leftAlias, rightAlias, filter) {
 		const quote = getSessionSingleton(context, 'quote');
-		leftAlias = quote(leftAlias);
-		rightAlias = quote(rightAlias);
+		const leftAliasRaw = leftAlias;
+		const rightAliasRaw = rightAlias;
+		leftAlias = quote(leftAliasRaw);
+		rightAlias = quote(rightAliasRaw);
 		var sql = '';
 		var delimiter = '';
 		for (var i = 0; i < leftColumns.length; i++) {
@@ -4147,7 +4149,7 @@ function requireNewShallowJoinSqlCore () {
 			sql += delimiter + leftAlias + '.' + quote(leftColumn._dbName) + '=' + rightAlias + '.' + quote(rightColumn._dbName);
 		}
 
-		sql += newDiscriminatorSql(context, rightTable, rightAlias);
+		sql += newDiscriminatorSql(context, rightTable, rightAliasRaw);
 		var result = newParameterized(sql);
 		if (filter)
 			result = result.append(delimiter).append(filter);

dist/index.mjs

@@ -4133,8 +4133,10 @@ function requireNewShallowJoinSqlCore () {
 
 	function _new(context, rightTable, leftColumns, rightColumns, leftAlias, rightAlias, filter) {
 		const quote = getSessionSingleton(context, 'quote');
-		leftAlias = quote(leftAlias);
-		rightAlias = quote(rightAlias);
+		const leftAliasRaw = leftAlias;
+		const rightAliasRaw = rightAlias;
+		leftAlias = quote(leftAliasRaw);
+		rightAlias = quote(rightAliasRaw);
 		var sql = '';
 		var delimiter = '';
 		for (var i = 0; i < leftColumns.length; i++) {
@@ -4148,7 +4150,7 @@ function requireNewShallowJoinSqlCore () {
 			sql += delimiter + leftAlias + '.' + quote(leftColumn._dbName) + '=' + rightAlias + '.' + quote(rightColumn._dbName);
 		}
 
-		sql += newDiscriminatorSql(context, rightTable, rightAlias);
+		sql += newDiscriminatorSql(context, rightTable, rightAliasRaw);
 		var result = newParameterized(sql);
 		if (filter)
 			result = result.append(delimiter).append(filter);

docs/changelog.md

@@ -1,4 +1,6 @@
 ## Changelog
+__4.9.1__  
+Fix: Avoid double-quoting aliases in discriminator join SQL [#144](https://github.com/alfateam/orange-orm/issues/144)    
 __4.9.0__  
 Node.js 22.5+: Continues using built-in `node:sqlite` (no action needed)  
 Node.js 18-22.4: Now requires `better-sqlite3` instead of `sqlite3`  

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "orange-orm",
-    "version": "4.9.0",
+    "version": "4.9.1",
     "publishConfig": {
         "access": "public"
     },