Skip to content

Commit 22c26d9

Browse files
committed
fixes nemo interface over QQ for elimination orderings
1 parent 901d3cb commit 22c26d9

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/interfaces/nemo.jl

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,9 @@ function _convert_rational_array_to_abstract_algebra(
135135
eliminate::Int=0
136136
)
137137

138+
# Note: Over QQ msolve already returns the eliminated basis
139+
# only in order to save memory due to possible huge
140+
# coefficient sizes.
138141
if characteristic(R) != 0
139142
error("We assume QQ as base field here.")
140143
end
@@ -144,21 +147,10 @@ function _convert_rational_array_to_abstract_algebra(
144147
CR = coefficient_ring(R)
145148

146149
basis = (typeof(R(0)))[]
147-
#= basis = Vector{MPolyRingElem}(undef, bld) =#
148150

149151
len = 0
150152

151-
if eliminate > 0
152-
z = zeros(Int, eliminate)
153-
end
154153
for i in 1:nr_gens
155-
#= check if element is part of the eliminated basis =#
156-
if eliminate > 0
157-
cmp = convert(Vector{Int}, bexp[(len)*nr_vars+1:(len+1)*nr_vars])
158-
if cmp[1:eliminate] > z
159-
continue
160-
end
161-
end
162154
if bcf[len+1] == 0
163155
push!(basis, R(0))
164156
else

0 commit comments

Comments
 (0)