Merge pull request #7 from ederc/rational-solutions-fixes

Rational solutions fixes

Author: ederc

docs/src/solvers.md

@@ -44,5 +44,14 @@ The underlying engine is provided by msolve.
         info_level::Int=0,
         precision::Int=32
         )
+    rational_solutions(
+        I::Ideal{T} where T <: MPolyElem;
+        initial_hts::Int=17,
+        nr_thrds::Int=1,
+        max_nr_pairs::Int=0,
+        la_option::Int=2,
+        info_level::Int=0,
+        precision::Int=32
+        )
 ```
 

src/algorithms/solvers.jl

@@ -280,10 +280,10 @@ julia> rat_sols = rational_solutions(I)
  [1//3, 0, 1//3]
 
 julia> map(r->map(p->evaluate(p, r), I.gens), rat_sols)
-4-element Vector{Vector{fmpq}}:
+2-element Vector{Vector{fmpq}}:
  [0, 0, 0]
  [0, 0, 0]
-
+```
 """
 function rational_solutions(
         I::Ideal{T} where T <: MPolyElem;     # input generators

src/exports.jl

@@ -1,3 +1,3 @@
 export PolynomialRing, MPolyRing, GFElem, MPoly, MPolyElem, FiniteField, GF,
        characteristic, ZZ, QQ, vars, nvars, ngens, fmpz, fmpq, fmpq_poly,
-       base_ring, coefficient_ring
+       base_ring, coefficient_ring, evaluate

src/imports.jl

@@ -12,6 +12,7 @@ import Nemo:
     divides,
     divisor_sigma,
     euler_phi,
+    evaluate,
     factorial,
     fibonacci,
     fits,

test/algorithms/solvers.jl

@@ -12,7 +12,10 @@
             [7087075322218650694049//37778931862957161709568, 1480060550928923391483//18889465931478580854784, 2780329556045248126029//37778931862957161709568, 38421910449864642395061//151115727451828646838272],
             [196765270119568550571//590295810358705651712, 0, 1//2361183241434822606848, 787061080478274202283//2361183241434822606848]
                             ]
+    rat_sols = Vector{fmpq}[[49, 0, 0, 0], [49//3, 0, 0, 1//3]]
+
     @test sols == real_solutions(I)
+    @test rat_sols == rational_solutions(I)
     @test I.real_sols == real_solutions(I)
 
     C, x = PolynomialRing(QQ, "x")