Skip to content

Commit ddedb11

Browse files
committed
different prime number for gencheck
1 parent 850880e commit ddedb11

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/algorithms/param-curve.jl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,10 @@ function rational_curve_parametrization(
7373
while any(is_divisible_by.(val, Ref(lucky_prime)))
7474
val = rand(-bif_bound:bif_bound, 2)
7575
end
76-
local INEW = Ideal(change_base_ring.(Ref(GF(lucky_prime)), vcat(F, val[1]*gens(R)[N-1] - val[2])))
77-
@assert(dimension(INEW)==0 && hilbert_degree(INEW) == DEG, "The curve is not in generic position")
76+
Fnew = vcat(F, val[1]*gens(R)[N-1] + val[2])
77+
@time new_lucky_prime = _generate_lucky_primes(Fnew, one(ZZ)<<30, one(ZZ)<<31-1, 1) |> first
78+
local INEW = Ideal(change_base_ring.(Ref(GF(new_lucky_prime)), Fnew))
79+
@assert(dimension(INEW) == 0 && hilbert_degree(INEW) == DEG, "The curve is not in generic position")
7880
end end
7981

8082
# Compute DEG+2 evaluations of x in the param (whose total deg is bounded by DEG)
@@ -160,7 +162,6 @@ function _add_genvars(
160162
ngenvars::Int,
161163
cfs_lfs::Vector{Vector{ZZRingElem}} = Vector{ZZRingElem}[]
162164
)
163-
164165
if length(cfs_lfs) > ngenvars
165166
error("Too many linear forms provided ($(length(cfs_lfs))>$(ngenvars))")
166167
end

0 commit comments

Comments
 (0)