fix detecting false as empty fields

Author: algo7

app.js

@@ -113,33 +113,41 @@ const emptyInputCheck = ({
             return;
         }
 
-        //Array for storing non-0 values
+        // Array for storing non-0 values
         let checkZ = [];
+        // Array for storing 0s
         let zArray = [];
+        // Array for storing falses
+        let fArray = [];
+        // Array for storing the keys
         let KeyArray = [];
 
         //Extract the value from the request body
         for (const key in body) {
 
             const element = body[key];
 
-            if (element !== 0) {
+            if (element !== 0 && element !== false) {
                 checkZ.push(element);
                 KeyArray.push(key);
             }
 
+            if (element === false) {
+                fArray.push(element);
+            }
+
             if (element === 0) {
                 zArray.push(element);
             }
         }
 
-        //Make sure the array is not empty (0 counts as a valid value)
-        if (checkZ.length === 0 && zArray.length === 0) {
+        //Make sure the array is not empty (0 & false count as valid values)
+        if (checkZ.length === 0 && zArray.length === 0 && fArray.length === 0) {
             res.status(400).json({ msg: emptyBodyMsg, });
             return;
         }
 
-        //Check for falsy values in the array without 0s
+        //Check for falsy values in the array without 0s and falses
         for (let index = 0; index < checkZ.length; index++) {
             const nonZinput = checkZ[index];
             const nonZinputKey = KeyArray[index];

test/main.test.js

@@ -144,6 +144,17 @@ describe('Testing the Input Validation Module', () => {
                 });
         });
 
+        test('Sending POST Request with a Body that Contains a Field with Value false', () => {
+            request.method = 'POST';
+            request.data.testField = false;
+            expect.assertions(1);
+            return axios(request)
+                .then(data => {
+                    const resBd = data.data.msg;
+                    expect(resBd).toBe(false);
+                });
+        });
+
         test('Sending POST Request with an Empty Body', () => {
 
             request.method = 'POST';

test/server.js

@@ -1,5 +1,6 @@
 //Dependencies
 const express = require('express');
+const axios = require('axios').default;
 const bodyParser = require('body-parser');
 const { routeCheck, emptyInputCheck, } = require('../app');
 
@@ -15,6 +16,10 @@ app.use(bodyParser.json({
     extended: true,
 }));
 
+app.use(bodyParser.urlencoded({
+    limit: '5mb',
+    extended: true,
+}));
 //Headers Settings
 app.all('*', (req, res, next) => {
     res.setHeader('Access-Control-Allow-Origin', 'http://localhost:5003');
@@ -53,7 +58,6 @@ const options = { redirectPath: '/PnF', };
 //The routeCheck middleware
 app.use(routeCheck(app, options));
 
-
 const server = app.listen(PORT);
 
 module.exports = { server, };