Skip to content
This repository was archived by the owner on Jan 31, 2022. It is now read-only.

Commit 6ddd9bf

Browse files
redoxredox
committed
Merge pull request #34 from algolia/feat/TestMessages
AndroidTest: Explicit messages on test failure
2 parents 3cc7f37 + c2f0b51 commit 6ddd9bf

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

‎algoliasearch/src/androidTest/java/com/algolia/search/saas/ApplicationTest.java‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public void testSearchAsync() throws Exception {
9393
class Listener implements SearchListener {
9494
@Override
9595
public void searchResult(Index index, Query query, JSONObject results) {
96-
assertEquals(objects.size(), results.optInt("nbHits"));
96+
assertEquals("Result length does not match nbHits", objects.size(), results.optInt("nbHits"));
9797
signal.countDown();
9898
}
9999

@@ -107,7 +107,7 @@ public void searchError(Index index, Query query, AlgoliaException e) {
107107
final Listener searchListener = new Listener();
108108

109109
index.searchASync(new Query(), searchListener);
110-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
110+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
111111
}
112112

113113
@UiThreadTest
@@ -117,7 +117,7 @@ public void testSearchDisjunctiveFacetingAsync() throws Exception {
117117
class Listener implements SearchDisjunctiveFacetingListener {
118118
@Override
119119
public void searchDisjunctiveFacetingResult(Index index, Query query, List<String> disjunctiveFacets, Map<String, List<String>> refinements, JSONObject results) {
120-
assertEquals(objects.size(), results.optInt("nbHits"));
120+
assertEquals("Result length does not match nbHits", objects.size(), results.optInt("nbHits"));
121121
signal.countDown();
122122
}
123123

@@ -131,7 +131,7 @@ public void searchDisjunctiveFacetingError(Index index, Query query, List<String
131131
final Listener searchListener = new Listener();
132132

133133
index.searchDisjunctiveFacetingAsync(new Query(), new ArrayList<String>(), new HashMap<String, List<String>>(), searchListener);
134-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
134+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
135135
}
136136

137137
@UiThreadTest
@@ -141,7 +141,7 @@ public void testAddObjectAsync() throws Exception {
141141
class Listener implements IndexingListener {
142142
@Override
143143
public void indexingResult(Index index, TaskParams.Indexing context, JSONObject results) {
144-
assertFalse(results.optString("objectID").equals(""));
144+
assertFalse("Result has no objectId", results.optString("objectID").equals(""));
145145
signal.countDown();
146146
}
147147

@@ -155,7 +155,7 @@ public void indexingError(Index index, TaskParams.Indexing context, AlgoliaExcep
155155
final Listener indexingListener = new Listener();
156156

157157
index.addObjectASync(new JSONObject("{\"city\": \"New York\"}"), indexingListener);
158-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
158+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
159159
}
160160

161161
@UiThreadTest
@@ -165,7 +165,7 @@ public void testAddObjectWithObjectIDAsync() throws Exception {
165165
class Listener implements IndexingListener {
166166
@Override
167167
public void indexingResult(Index index, TaskParams.Indexing context, JSONObject results) {
168-
assertTrue(results.optString("objectID").equals("a1b2c3"));
168+
assertTrue("Object has unexpected objectId", results.optString("objectID").equals("a1b2c3"));
169169
signal.countDown();
170170
}
171171

@@ -179,7 +179,7 @@ public void indexingError(Index index, TaskParams.Indexing context, AlgoliaExcep
179179
final Listener indexingListener = new Listener();
180180

181181
index.addObjectASync(new JSONObject("{\"city\": \"New York\"}"), "a1b2c3", indexingListener);
182-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
182+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
183183
}
184184

185185
@UiThreadTest
@@ -189,7 +189,7 @@ public void testAddObjectsAsync() throws Exception {
189189
class Listener implements IndexingListener {
190190
@Override
191191
public void indexingResult(Index index, TaskParams.Indexing context, JSONObject results) {
192-
assertEquals(2, results.optJSONArray("objectIDs").length());
192+
assertEquals("Objects have unexpected objectId count", 2, results.optJSONArray("objectIDs").length());
193193
signal.countDown();
194194
}
195195

@@ -203,7 +203,7 @@ public void indexingError(Index index, TaskParams.Indexing context, AlgoliaExcep
203203
final Listener indexingListener = new Listener();
204204

205205
index.addObjectsASync(new JSONArray("[{\"city\": \"New York\"}, {\"city\": \"Paris\"}]"), indexingListener);
206-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
206+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
207207
}
208208

209209
@UiThreadTest
@@ -213,7 +213,7 @@ public void testSaveObjectAsync() throws Exception {
213213
class Listener implements IndexingListener {
214214
@Override
215215
public void indexingResult(Index index, TaskParams.Indexing context, JSONObject results) {
216-
assertTrue(results.optString("objectID").equals("a1b2c3"));
216+
assertTrue("Object has unexpected objectId", results.optString("objectID").equals("a1b2c3"));
217217
signal.countDown();
218218
}
219219

@@ -227,7 +227,7 @@ public void indexingError(Index index, TaskParams.Indexing context, AlgoliaExcep
227227
final Listener indexingListener = new Listener();
228228

229229
index.saveObjectASync(new JSONObject("{\"city\": \"New York\"}"), "a1b2c3", indexingListener);
230-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
230+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
231231
}
232232

233233
@UiThreadTest
@@ -237,9 +237,9 @@ public void testSaveObjectsAsync() throws Exception {
237237
class Listener implements IndexingListener {
238238
@Override
239239
public void indexingResult(Index index, TaskParams.Indexing context, JSONObject results) {
240-
assertEquals(2, results.optJSONArray("objectIDs").length());
241-
assertEquals(123, results.optJSONArray("objectIDs").optInt(0));
242-
assertEquals(456, results.optJSONArray("objectIDs").optInt(1));
240+
assertEquals("Objects have unexpected objectId count", 2, results.optJSONArray("objectIDs").length());
241+
assertEquals("Object has unexpected objectId", 123, results.optJSONArray("objectIDs").optInt(0));
242+
assertEquals("Object has unexpected objectId", 456, results.optJSONArray("objectIDs").optInt(1));
243243
signal.countDown();
244244
}
245245

@@ -253,7 +253,7 @@ public void indexingError(Index index, TaskParams.Indexing context, AlgoliaExcep
253253
final Listener indexingListener = new Listener();
254254

255255
index.saveObjectsASync(new JSONArray("[{\"city\": \"New York\", \"objectID\": 123}, {\"city\": \"Paris\", \"objectID\": 456}]"), indexingListener);
256-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
256+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
257257
}
258258

259259
@UiThreadTest
@@ -263,8 +263,8 @@ public void testGetObjectAsync() throws Exception {
263263
class Listener implements GetObjectsListener {
264264
@Override
265265
public void getObjectsResult(Index index, TaskParams.GetObjects context, JSONObject results) {
266-
assertTrue(results.optString("objectID").equals(ids.get(0)));
267-
assertTrue(results.optString("city").equals("San Francisco"));
266+
assertTrue("Object has unexpected objectId", results.optString("objectID").equals(ids.get(0)));
267+
assertTrue("Object has unexpected 'city' attribute", results.optString("city").equals("San Francisco"));
268268
signal.countDown();
269269
}
270270

@@ -278,7 +278,7 @@ public void getObjectsError(Index index, TaskParams.GetObjects context, AlgoliaE
278278
final Listener getObjectsListener = new Listener();
279279

280280
index.getObjectASync(ids.get(0), getObjectsListener);
281-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
281+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
282282
}
283283

284284
@UiThreadTest
@@ -288,8 +288,8 @@ public void testGetObjectWithAttributesToRetrieveAsync() throws Exception {
288288
class Listener implements GetObjectsListener {
289289
@Override
290290
public void getObjectsResult(Index index, TaskParams.GetObjects context, JSONObject results) {
291-
assertTrue(results.optString("objectID").equals(ids.get(0)));
292-
assertFalse(results.has("city"));
291+
assertTrue("Object has unexpected objectId", results.optString("objectID").equals(ids.get(0)));
292+
assertFalse("Object has unexpected 'city' attribute", results.has("city"));
293293
signal.countDown();
294294
}
295295

@@ -305,7 +305,7 @@ public void getObjectsError(Index index, TaskParams.GetObjects context, AlgoliaE
305305
List<String> attributesToRetrieve = new ArrayList<String>();
306306
attributesToRetrieve.add("objectID");
307307
index.getObjectASync(ids.get(0), attributesToRetrieve, getObjectsListener);
308-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
308+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
309309
}
310310

311311
@UiThreadTest
@@ -316,8 +316,8 @@ class Listener implements GetObjectsListener {
316316
@Override
317317
public void getObjectsResult(Index index, TaskParams.GetObjects context, JSONObject results) {
318318
JSONArray res = results.optJSONArray("results");
319-
assertTrue(res.optJSONObject(0).optString("objectID").equals(ids.get(0)));
320-
assertTrue(res.optJSONObject(1).optString("objectID").equals(ids.get(1)));
319+
assertTrue("Object has unexpected objectId", res.optJSONObject(0).optString("objectID").equals(ids.get(0)));
320+
assertTrue("Object has unexpected objectId", res.optJSONObject(1).optString("objectID").equals(ids.get(1)));
321321
signal.countDown();
322322
}
323323

@@ -331,7 +331,7 @@ public void getObjectsError(Index index, TaskParams.GetObjects context, AlgoliaE
331331
final Listener getObjectsListener = new Listener();
332332

333333
index.getObjectsASync(ids, getObjectsListener);
334-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
334+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
335335
}
336336

337337
@UiThreadTest
@@ -353,7 +353,7 @@ public void indexingError(Index index, TaskParams.Indexing context, AlgoliaExcep
353353

354354
@Override
355355
public void waitTaskResult(Index index, String taskID) {
356-
assertFalse(taskID.equals(""));
356+
assertFalse("Task ID not found", taskID.equals(""));
357357
signal.countDown();
358358
}
359359

@@ -367,6 +367,6 @@ public void waitTaskError(Index index, String taskID, AlgoliaException e) {
367367
final Listener listener = new Listener();
368368

369369
index.addObjectASync(new JSONObject("{\"city\": \"New York\"}"), listener);
370-
assertTrue(signal.await(Helpers.wait, TimeUnit.SECONDS));
370+
assertTrue("No callback was called", signal.await(Helpers.wait, TimeUnit.SECONDS));
371371
}
372372
}

0 commit comments

Comments
 (0)