fix(Query): Reimplement missing overloads for arguments as List

Author: PLNech

algoliasearch/src/main/java/com/algolia/search/saas/Query.java

@@ -250,6 +250,14 @@ public Integer getAroundRadius() {
 
     private static final String KEY_ATTRIBUTES_TO_HIGHLIGHT = "attributesToHighlight";
 
+    /**
+     * Deprecated, use {@link #setAttributesToHighlight(String...)}
+     */
+    @Deprecated
+    public @NonNull Query setAttributesToHighlight(List<String> attributes) {
+        return set(KEY_ATTRIBUTES_TO_HIGHLIGHT, buildJSONArray((String[]) attributes.toArray()));
+    }
+
     /**
      * Specify the list of attribute names to highlight. By default indexed
      * attributes are highlighted.
@@ -265,6 +273,14 @@ public String[] getAttributesToHighlight() {
     private static final String KEY_ATTRIBUTES_TO_RETRIEVE = "attributesToRetrieve";
     private static final String KEY_ATTRIBUTES_TO_RETRIEVE_LEGACY = "attributes";
 
+    /**
+     * Deprecated, use {@link #setAttributesToRetrieve(String...)}
+     */
+    @Deprecated
+    public @NonNull Query setAttributesToRetrieve(List<String> attributes) {
+        return set(KEY_ATTRIBUTES_TO_RETRIEVE, buildJSONArray((String[]) attributes.toArray()));
+    }
+
     /**
      * Specify the list of attribute names to retrieve. By default all
      * attributes are retrieved.

algoliasearch/src/test/java/com/algolia/search/saas/QueryTest.java

@@ -30,6 +30,7 @@
 import java.io.UnsupportedEncodingException;
 import java.net.URLEncoder;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 
 import static junit.framework.Assert.assertFalse;
@@ -295,6 +296,11 @@ public void attributesToHighlight() {
         assertArrayEquals(new String[]{ "foo", "bar" }, query.getAttributesToHighlight());
         assertEquals("[\"foo\",\"bar\"]", query.get("attributesToHighlight"));
         assertArrayEquals(query.getAttributesToHighlight(), Query.parse(query.build()).getAttributesToHighlight());
+
+        query.setAttributesToHighlight(Arrays.asList("foo", "bar"));
+        assertArrayEquals(new String[]{ "foo", "bar" }, query.getAttributesToHighlight());
+        assertEquals("[\"foo\",\"bar\"]", query.get("attributesToHighlight"));
+        assertArrayEquals(query.getAttributesToHighlight(), Query.parse(query.build()).getAttributesToHighlight());
     }
 
     @Test
@@ -305,6 +311,11 @@ public void attributesToRetrieve() {
         assertArrayEquals(new String[]{ "foo", "bar" }, query.getAttributesToRetrieve());
         assertEquals("[\"foo\",\"bar\"]", query.get("attributesToRetrieve"));
         assertArrayEquals(query.getAttributesToRetrieve(), Query.parse(query.build()).getAttributesToRetrieve());
+
+        query.setAttributesToRetrieve(Arrays.asList("foo", "bar"));
+        assertArrayEquals(new String[]{ "foo", "bar" }, query.getAttributesToRetrieve());
+        assertEquals("[\"foo\",\"bar\"]", query.get("attributesToRetrieve"));
+        assertArrayEquals(query.getAttributesToRetrieve(), Query.parse(query.build()).getAttributesToRetrieve());
     }
 
     @Test