Fix Maven publication (again)

It’s becoming kind of a recurring joke… :/

A single Maven upload task can only upload to a single repository. So I created another task (`testUploadArchives`) to test the upload locally.

Also, I decide to disable automatic Sonatype release and Git push. The reasons are:

- We cannot know what was the previous state of the staging repository on Sonatype. => Better check manually before releasing!
- We don’t want to push before the release is actually available for download, which can take time.

Author: Clément Le Provost

algoliasearch/common.gradle

@@ -121,47 +121,72 @@ uploadArchives {
         beforeDeployment {
             MavenDeployment deployment -> signing.signPom(deployment)
         }
+        editPom(pom)
 
-        // POM metadata.
-        pom.groupId = PUBLISH_GROUP_ID
-        pom.artifactId = PUBLISH_ARTIFACT_ID
-        pom.version = PUBLISH_VERSION
-        pom.project {
-            name PUBLISH_NAME
-            packaging 'aar'
-            description PUBLISH_DESCRIPTION
-            url 'https://github.com/algolia/algoliasearch-client-android'
+        // Maven Central repository.
+        repository(url: "https://oss.sonatype.org/service/local/staging/deploy/maven2/") {
+            authentication(
+                userName: project.hasProperty('nexusUsername') ? project['nexusUsername'] : 'FIXME',
+                password: project.hasProperty('nexusPassword') ? project['nexusPassword'] : 'FIXME'
+            )
+        }
+        // Maven Central snapshot repository.
+        snapshotRepository(url: "https://oss.sonatype.org/content/repositories/snapshots/") {
+            authentication(
+                userName: project.hasProperty('nexusUsername') ? project['nexusUsername'] : 'FIXME',
+                password: project.hasProperty('nexusPassword') ? project['nexusPassword'] : 'FIXME'
+            )
+        }
+    }
+}
 
-            scm {
-                url 'https://github.com/algolia/algoliasearch-client-android'
-                connection 'scm:git:https://github.com/algolia/algoliasearch-client-android.git'
-            }
+// Test uploading of the archives to a local directory.
+task testUploadArchives(type: Upload) {
+    configuration = configurations.archives
+    uploadDescriptor = true
+    repositories.mavenDeployer {
+        beforeDeployment {
+            MavenDeployment deployment -> signing.signPom(deployment)
+        }
+        editPom(pom)
+        repository(url: "file://$buildDir/mvnrep")
+    }
+}
 
-            licenses {
-                license {
-                    name 'MIT'
-                    url 'http://opensource.org/licenses/MIT'
-                }
-            }
+// Edit the Maven POM.
+//
+// NOTE: This function is meant to factorize POM generation between the built-in `uploadArchives` and the custom
+// `testUploadArchives` tasks.
+//
+def editPom(pom) {
+    // POM metadata.
+    pom.groupId = PUBLISH_GROUP_ID
+    pom.artifactId = PUBLISH_ARTIFACT_ID
+    pom.version = PUBLISH_VERSION
+    pom.project {
+        name PUBLISH_NAME
+        packaging 'aar'
+        description PUBLISH_DESCRIPTION
+        url 'https://github.com/algolia/algoliasearch-client-android'
+
+        scm {
+            url 'https://github.com/algolia/algoliasearch-client-android'
+            connection 'scm:git:https://github.com/algolia/algoliasearch-client-android.git'
+        }
 
-            developers {
-                developer {
-                    id 'algolia'
-                    name 'The Algolia Team'
-                    email '[email protected]'
-                }
+        licenses {
+            license {
+                name 'MIT'
+                url 'http://opensource.org/licenses/MIT'
             }
         }
 
-        // Local repository, to test publication contents.
-        repository(url: "file://$buildDir/mvnrep")
-
-        // Maven Central repository.
-        repository(url: PUBLISH_VERSION.endsWith("-SNAPSHOT") ? "https://oss.sonatype.org/content/repositories/snapshots/" : "https://oss.sonatype.org/service/local/staging/deploy/maven2/") {
-            authentication(
-                userName: project.hasProperty('nexusUsername') ? project['nexusUsername'] : 'FIXME',
-                password: project.hasProperty('nexusPassword') ? project['nexusPassword'] : 'FIXME'
-            )
+        developers {
+            developer {
+                id 'algolia'
+                name 'The Algolia Team'
+                email '[email protected]'
+            }
         }
     }
 }

release.sh

@@ -38,29 +38,48 @@ $SELF_ROOT/tools/update-version.sh $VERSION_CODE
 
 for flavor in online offline
 do
-    echo "========== Processing flavor '$flavor' =========="
+    echo "==================== Processing flavor '$flavor' ===================="
     $SELF_ROOT/select-flavor.sh $flavor
     $SELF_ROOT/gradlew clean
-    $SELF_ROOT/gradlew uploadArchives
+
+    # Test publication locally.
+    echo "-------------------- Publishing locally --------------------"
+    $SELF_ROOT/gradlew testUploadArchives
     if [[ $flavor = "online" ]]; then
         module_name="algoliasearch-android"
     elif [[ $flavor = "offline" ]]; then
         module_name="algoliasearch-offline-android"
     fi
     # Dump the contents that has been published, just for the sake of manual checking.
     $SELF_ROOT/tools/dump-local-mvnrep.sh $module_name
-    echo "---------- Testing publication ----------"
+    echo "-------------------- Testing publication --------------------"
     $SELF_ROOT/tools/test-publication.sh $module_name $VERSION_CODE
-done
 
-echo "SUCCESS: closing and releasing new version..."
-$SELF_ROOT/gradlew closeAndPromoteRepository 1>/dev/null
+    # Perform the actual publication.
+    echo "-------------------- Publishing remotely --------------------"
+    $SELF_ROOT/gradlew uploadArchives
+done
 
 # Revert flavor to original.
 git checkout $SELF_ROOT/algoliasearch/build.gradle
 
-# Commit to Git.
+# Commit to Git... but do *not* push (see below).
 git add .
 git commit -m "Version $VERSION_CODE"
 git tag $VERSION_CODE
-git push --tags origin master
+
+echo "SUCCESS!"
+
+# NOTE: We don't automatically publish nor Git push. Why?
+# - We cannot be sure what the state of the staging repository was at the beginning of the script. So publishing
+#   without controlling it manually is risky.
+# - We don't want to push to Git before the release is actually available on Maven Central, which can take a few hours
+#   after the staging repository has been promoted.
+#
+cat <<EOF
+Next steps:
+- Check the staging repository on Sonatype.
+- If everything is OK: close, release and drop the staging repository.
+- Git commit and tag.
+- When the release is available on Maven Central: Git push.
+EOF