fix: AlgoliaHelper.GetObjectID (#824)

Author: sbellone

src/Algolia.Search.Test/Utils/AlgoliaHelperTest.cs

@@ -0,0 +1,42 @@
+using Algolia.Search.Utils;
+using Newtonsoft.Json.Linq;
+using NUnit.Framework;
+
+namespace Algolia.Search.Test.Utils;
+
+class TestRecord
+{
+    public string ObjectID { get; set; }
+    public string Name { get; set; }
+}
+
+[TestFixture]
+[Parallelizable]
+public class AlgoliaHelperTest
+{
+    [Test]
+    [Parallelizable]
+    public void TestGetObjectIdFromClass()
+    {
+        var objectId = "1-2_1-2";
+        var record = new TestRecord
+        {
+            ObjectID = objectId,
+            Name = "this is a test"
+        };
+        Assert.AreEqual(objectId, AlgoliaHelper.GetObjectID(record));
+    }
+
+    [Test]
+    [Parallelizable]
+    public void TestGetObjectIdFromJObject()
+    {
+        var objectId = "1-2_1-2";
+        var record = new JObject
+        {
+            { "objectID", objectId },
+            { "name", "this is a test" }
+        };
+        Assert.AreEqual(objectId, AlgoliaHelper.GetObjectID(record));
+    }
+}

src/Algolia.Search/Utils/AlgoliaHelper.cs

@@ -105,11 +105,11 @@ internal static string GetObjectID<T>(T data)
 
             if (itemType == typeof(JObject))
             {
-                JProperty objectID = JObject.FromObject(data).Property("objectID");
+                var objectIdJProperty = JObject.FromObject(data).Property("objectID");
 
-                if (objectID != null && objectID.ToString() != "")
+                if (objectIdJProperty != null && !string.IsNullOrWhiteSpace(objectIdJProperty.Value.ToString()))
                 {
-                    return objectID.ToString();
+                    return objectIdJProperty.Value.ToString();
                 }
             }