Skip to content

Commit dce3e44

Browse files
fix(query rules): Suppress rule condition pattern marshalling in case of empty anchoring (#689)
1 parent 3e8fd6d commit dce3e44

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

algolia/search/rule_condition.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ type RuleCondition struct {
1212

1313
func (c RuleCondition) MarshalJSON() ([]byte, error) {
1414
m := make(map[string]interface{})
15-
if c.Anchoring != "" || c.Pattern != "" {
15+
if c.Anchoring != "" {
1616
m["anchoring"] = c.Anchoring
1717
m["pattern"] = c.Pattern
1818
}

algolia/search/rule_condition_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ func TestRuleCondition_MarshalJSON(t *testing.T) {
4444
Alternatives: nil,
4545
Filters: "",
4646
},
47-
`{"anchoring": "", "pattern": "Pattern"}`,
47+
`{}`,
4848
},
4949
{
5050
RuleCondition{
@@ -106,7 +106,11 @@ func TestRuleCondition_MarshalJSON(t *testing.T) {
106106

107107
// Compare the two RuleConditions
108108
require.Equal(t, c.condition.Anchoring, condition.Anchoring)
109-
require.Equal(t, c.condition.Pattern, condition.Pattern)
109+
if c.condition.Anchoring == "" {
110+
require.Equal(t, condition.Pattern, "")
111+
} else {
112+
require.Equal(t, c.condition.Pattern, condition.Pattern)
113+
}
110114
require.Equal(t, c.condition.Context, condition.Context)
111115
if c.condition.Alternatives == nil {
112116
require.Nil(t, condition.Alternatives)

0 commit comments

Comments
 (0)