Skip to content

Commit 01b0bcd

Browse files
authored
fix: serialize ConsequenceParams empty query (#766)
1 parent f41e062 commit 01b0bcd

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

algoliasearch-core/src/main/java/com/algolia/search/models/rules/ConsequenceQuery.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.algolia.search.models.rules;
22

33
import com.algolia.search.Defaults;
4-
import com.algolia.search.util.AlgoliaUtils;
54
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
65
import com.fasterxml.jackson.core.JsonGenerator;
76
import com.fasterxml.jackson.core.JsonParser;
@@ -80,7 +79,7 @@ public void serialize(ConsequenceQuery value, JsonGenerator gen, SerializerProvi
8079
* Consequence query edits will override regular "query" - both can't be set at the same time
8180
* https://www.algolia.com/doc/api-reference/api-methods/save-rule/#method-param-query
8281
* */
83-
if (!AlgoliaUtils.isNullOrEmptyWhiteSpace(value.getQueryString())) {
82+
if (value.getQueryString() != null) {
8483
gen.writeString(value.getQueryString());
8584
} else {
8685
gen.writeStartObject();

algoliasearch-core/src/test/java/com/algolia/search/JacksonParserTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1010,4 +1010,11 @@ void recommendations() throws JsonProcessingException {
10101010
assertThat(recommendHit.getObjectID()).isEqualTo("D05927-8161-111");
10111011
assertThat(recommendHit.getScore()).isEqualTo(32.72f);
10121012
}
1013+
1014+
@Test
1015+
void consequenceParams_emptyQuery_nullEdits() throws JsonProcessingException {
1016+
ConsequenceParams params = new ConsequenceParams().setQuery("");
1017+
String json = Defaults.getObjectMapper().writeValueAsString(params);
1018+
assertThat(json).isEqualTo("{\"query\":\"\"}");
1019+
}
10131020
}

0 commit comments

Comments
 (0)