fix(requester-node-http): fix handling chunked responses fix #1161 (#1164)

Author: nunomaduro

package.json

@@ -73,6 +73,7 @@
     "lerna": "3.20.2",
     "nock": "12.0.2",
     "prettier": "1.19.1",
+    "readable-stream": "3.6.0",
     "rollup": "1.32.1",
     "rollup-plugin-babel": "4.4.0",
     "rollup-plugin-filesize": "6.2.1",

packages/requester-node-http/src/__tests__/unit/node-http-requester.test.ts

@@ -1,5 +1,7 @@
 import { MethodEnum, Request } from '@algolia/requester-common';
 import nock from 'nock';
+// @ts-ignore
+import { Readable } from 'readable-stream';
 
 import { createNodeHttpRequester } from '../..';
 
@@ -87,6 +89,27 @@ describe('status code handling', () => {
     expect(response.content).toBe(JSON.stringify(body));
     expect(response.isTimedOut).toBe(false);
   });
+
+  it('handles chunked responses inside unicode character boundaries', async () => {
+    const testdata = Buffer.from('äöü');
+
+    // create a test response stream that is chunked inside a unicode character
+    function* generate() {
+      yield testdata.slice(0, 3);
+      yield testdata.slice(3);
+    }
+
+    const testStream = Readable.from(generate());
+
+    nock('https://algolia-dns.net', { reqheaders: headers })
+      .post('/foo')
+      .query({ 'x-algolia-header': 'foo' })
+      .reply(200, testStream);
+
+    const response = await requester.send(requestStub);
+
+    expect(response.content).toEqual(testdata.toString());
+  });
 });
 
 describe('timeout handling', () => {

packages/requester-node-http/src/createNodeHttpRequester.ts

@@ -27,10 +27,12 @@ export function createNodeHttpRequester(): Requester & Destroyable {
         };
 
         const req = (url.protocol === 'https:' ? https : http).request(options, response => {
-          // eslint-disable-next-line functional/no-let
-          let content = '';
+          // eslint-disable-next-line functional/no-let, functional/prefer-readonly-type
+          let contentBuffers: Buffer[] = [];
 
-          response.on('data', chunk => (content += chunk));
+          response.on('data', chunk => {
+            contentBuffers = contentBuffers.concat(chunk);
+          });
 
           response.on('end', () => {
             // eslint-disable-next-line @typescript-eslint/no-use-before-define
@@ -40,7 +42,7 @@ export function createNodeHttpRequester(): Requester & Destroyable {
 
             resolve({
               status: response.statusCode || 0,
-              content,
+              content: Buffer.concat(contentBuffers).toString(),
               isTimedOut: false,
             });
           });

yarn.lock

@@ -8524,7 +8524,7 @@ read@1, read@~1.0.1:
     string_decoder "~1.1.1"
     util-deprecate "~1.0.1"
 
-"readable-stream@2 || 3", readable-stream@^3.0.2, readable-stream@^3.1.1, readable-stream@^3.4.0:
+"readable-stream@2 || 3", readable-stream@3.6.0, readable-stream@^3.0.2, readable-stream@^3.1.1, readable-stream@^3.4.0:
   version "3.6.0"
   resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-3.6.0.tgz#337bbda3adc0706bd3e024426a286d4b4b2c9198"
   integrity sha512-BViHy7LKeTz4oNnkcLJ+lVSL6vpiFeX6/d3oSH8zCW7UxP2onchk+vTGB143xuFjHS3deTgkKoXXymXqymiIdA==