Include input string in message about invalid json (#711)

Author: greg0ire

CHANGELOG.md

@@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased](https://github.com/algolia/algoliasearch-client-php/compare/3.3.2...master)
 
+### Added
+
+- Include input string in message about invalid json ([#711](https://github.com/algolia/algoliasearch-client-php/pull/711))
+
 ## [v3.3.2](https://github.com/algolia/algoliasearch-client-php/compare/3.3.1...3.3.2)
 
 ### Fixed

src/Support/Helpers.php

@@ -109,7 +109,15 @@ public static function json_decode($json, $assoc = false, $depth = 512)
     {
         $data = \json_decode($json, $assoc, $depth);
         if (JSON_ERROR_NONE !== json_last_error()) {
-            throw new \InvalidArgumentException('json_decode error: '.json_last_error_msg());
+            throw new \InvalidArgumentException(sprintf(
+                <<<'EXCEPTION'
+json_decode_error: %s
+input string: %s
+EXCEPTION
+            ,
+                json_last_error_msg(),
+                $json
+            ));
         }
 
         return $data;

tests/Unit/HelpersTest.php

@@ -79,4 +79,12 @@ public function testMapObjectIDsWithMissingPrimary()
         $objects = [['name' => 'test'], ['primary' => 1, 'name' => 'cool']];
         Helpers::mapObjectIDs('primary', $objects);
     }
+
+    public function testItMentionsTheInputStringWhenItIsInvalid(): void
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('this is not valid json');
+
+        Helpers::json_decode('this is not valid json');
+    }
 }