fix: getVersion should be in URL params not in the body

Author: TomKlotzPro

algoliasearch/search_index.py

@@ -236,6 +236,11 @@ def get_settings(self, request_options=None):
 
         params = {'getVersion': 2}
 
+        if request_options is None:
+            request_options = {'getVersion':2}
+        else:
+            request_options.append({'getVersion':2})
+
         raw_response = self._transporter.read(
             Verb.GET,
             endpoint('1/indexes/{}/settings', self._name),

algoliasearch/search_index_async.py

@@ -80,12 +80,15 @@ def browse_rules_async(self, request_options=None):
     def get_settings_async(self, request_options=None):  # type: ignore
         # type: (Optional[Union[dict, RequestOptions]]) -> dict
 
-        params = {'getVersion': 2}
+        if request_options == None:
+            request_options = {'getVersion':2}
+        else:
+            request_options.append({'getVersion':2})
 
         raw_response = yield from self._transporter_async.read(
             Verb.GET,
             endpoint('1/indexes/{}/settings', self._name),
-            params,
+            None,
             request_options
         )
 

tests/features/test_account_client.py

@@ -46,6 +46,18 @@ def test_cross_app_copy_index(self):
         self.assertEqual(self.index2.get_rule('one'), rule)
 
         # Assert synonyms got copied
+        list_synonyms1 = []
+        list_synonyms2 = []
+
+        for synonym1 in self.index.browse_synonyms():
+            list_synonyms1.append(synonym1)
+
+        for synonym2 in self.index2.browse_synonyms():
+            list_synonyms2.append(synonym2)
+
+        self.assertEqual(list_synonyms1,list_synonyms1)
+
+        # Assert synomys are the same
         self.assertEqual(self.index2.get_synonym('one'), synonym)
 
         # Assert that copying again fails because index already exists