fix(recommendation)!: remove recommendation client in favor of personalization (#554)

| Q                 | A
| ----------------- | ----------
| Bug fix?          | no
| New feature?      | no
| BC breaks?        | yes
| Related Issue | Fix #... <!-- will close issue automatically, if any
-->
| Need Doc update   | no

## Describe your change

https://algolia.atlassian.net/browse/DI-1010

~Months~ years ago we added a deprecation notice for the recommendation
client, since we will now release a new major, we can remove anything
related to this client.

deprecation PR
#536

Author: shortcuts

algoliasearch/configs.py

@@ -110,22 +110,6 @@ def build_hosts(self):
         )
 
 
-class RecommendationConfig(Config):
-    def __init__(self, app_id=None, api_key=None, region=None):
-        # type: (Optional[str], Optional[str], Optional[str]) -> None
-
-        self._region = "us" if region is None else region
-
-        super(RecommendationConfig, self).__init__(app_id, api_key)
-
-    def build_hosts(self):
-        # type: () -> HostsCollection
-
-        return HostsCollection(
-            [Host("{}.{}.{}".format("recommendation", self._region, "algolia.com"))]
-        )
-
-
 class PersonalizationConfig(Config):
     def __init__(self, app_id=None, api_key=None, region=None):
         # type: (Optional[str], Optional[str], Optional[str]) -> None

algoliasearch/recommendation_client.py

@@ -334,45 +334,6 @@ def wait_task(self, index_name, task_id, request_options=None):
 
         self.init_index(index_name).wait_task(task_id, request_options)
 
-    def set_personalization_strategy(self, strategy, request_options=None):
-        # type: (dict, Optional[Union[dict, RequestOptions]]) -> dict
-
-        warnings.warn(
-            "`%s.%s` is deprecated, use `%s.%s` instead."
-            % (
-                "SearchClient",
-                "set_personalization_strategy",
-                "PersonalizationClient",
-                "set_personalization_strategy",
-            ),
-            DeprecationWarning,
-        )
-
-        return self._transporter.write(
-            Verb.POST,
-            "1/recommendation/personalization/strategy",
-            strategy,
-            request_options,
-        )
-
-    def get_personalization_strategy(self, request_options=None):
-        # type: (Optional[Union[dict, RequestOptions]]) -> dict
-
-        warnings.warn(
-            "`%s.%s` is deprecated, use `%s.%s` instead."
-            % (
-                "SearchClient",
-                "get_personalization_strategy",
-                "PersonalizationClient",
-                "get_personalization_strategy",
-            ),
-            DeprecationWarning,
-        )
-
-        return self._transporter.read(
-            Verb.GET, "1/recommendation/personalization/strategy", None, request_options
-        )
-
     def save_dictionary_entries(
         self, dictionary, dictionary_entries, request_options=None
     ):

algoliasearch/recommendation_client_async.py

@@ -12,7 +12,6 @@
 from algoliasearch.insights_client import InsightsClient
 from algoliasearch.search_client import SearchClient, SearchConfig
 from algoliasearch.recommend_client import RecommendClient
-from algoliasearch.recommendation_client import RecommendationClient
 from algoliasearch.personalization_client import PersonalizationClient
 from algoliasearch.http.hosts import HostsCollection, Host
 from faker import Faker
@@ -90,24 +89,6 @@ def recommend_client(app_id=None, api_key=None):
 
         return Factory.decide(RecommendClient.create(app_id, api_key))
 
-    @staticmethod
-    def recommendation_client(app_id=None, api_key=None):
-        # type: (Optional[str], Optional[str]) -> RecommendationClient
-
-        warnings.warn(
-            "`%s` is deprecated, use `%s` instead."
-            % (
-                "RecommendationClient",
-                "PersonalizationClient",
-            ),
-            DeprecationWarning,
-        )
-
-        app_id = app_id if app_id is not None else Factory.get_app_id()
-        api_key = api_key if api_key is not None else Factory.get_api_key()
-
-        return Factory.decide(RecommendationClient.create(app_id, api_key))
-
     @staticmethod
     def personalization_client(app_id=None, api_key=None):
         # type: (Optional[str], Optional[str]) -> PersonalizationClient

algoliasearch/search_client.py

@@ -3,6 +3,7 @@ envlist =
     py{34,35,36,37,38,39,310,311}-sync
     py{34,35,36,37,38,39,310,311}-async
     format
+    format-fix
     types
 install_command = python -m pip install --user {opts} {packages}
 
@@ -61,6 +62,13 @@ commands =
     black --check algoliasearch/ tests/
     flake8 algoliasearch/ tests/
 
+[testenv:format-fix]
+basepython = python3.8
+deps =
+    black  {[versions]black}
+commands =
+    black algoliasearch/ tests/
+
 [testenv:release]
 basepython = python3.8
 deps =