feat(task): move wait_task and cie to the Client

Author: julienbourdeau

CHANGELOG.md

@@ -5,6 +5,16 @@
 
 <Contributors, please add your changes below this line>
 
+* 2 methods about taskID initially available in the `Index` moved to the `Client`. 
+    You could get some taskID from the engine without necessarily have an instance of Index, 
+    instead of instantiating an index that you won't need, you can now call wait_task and get_task_status on the client.
+    The original methods on the index still work and are **not** deprecated.
+ 
+    ```python
+    client.wait_ask(index_name, taskID)
+    client.get_task_status(index_name, taskID)
+    ```
+
 ### 1.16.0 - 2018-06-07
 
 🎉 Note to contributors:

algoliasearch/client.py

@@ -27,6 +27,7 @@
 import base64
 import random
 import sys
+import time
 from platform import python_version
 
 try:
@@ -257,6 +258,31 @@ def batch(self, requests, request_options=None):
         path = '/1/indexes/*/batch'
         return self._req(False, path, 'POST', request_options, data=requests)
 
+    def wait_task(self, index_name, task_id, time_before_retry=100, request_options=None):
+        """
+        Wait the publication of a task on the server.
+        All server task are asynchronous and you can check with this method
+        that the task is published.
+
+        @param index_name the index name associated with the taskID
+        @param task_id the id of the task returned by server
+        @param time_before_retry the time in milliseconds before retry (default = 100ms)
+        @param request_options
+        """
+        while True:
+            task = self.get_task(index_name, task_id, request_options)
+            if task['status'] == 'published':
+                return task
+            time.sleep(time_before_retry / 1000.0)
+
+    def get_task(self, index_name, task_id, request_options=None):
+        path = '/1/indexes/%s/task/%d' % (safe(index_name), task_id)
+        return self._req(True, path, 'GET', request_options)
+
+    def is_task_published(self, index_name, task_id, request_options=None):
+        task = self.get_task(index_name, task_id, request_options)
+        return task['status'] == 'published'
+
     @deprecated
     def listIndexes(self):
         return self.list_indexes()

algoliasearch/index.py

@@ -718,31 +718,10 @@ def waitTask(self, task_id, time_before_retry=100):
         return self.wait_task(task_id, time_before_retry)
 
     def wait_task(self, task_id, time_before_retry=100, request_options=None):
-        """
-        Wait the publication of a task on the server.
-        All server task are asynchronous and you can check with this method
-        that the task is published.
-
-        @param task_id the id of the task returned by server
-        @param time_before_retry the time in milliseconds before retry (default = 100ms)
-        """
-        path = '/task/%d' % task_id
-        while True:
-            res = self._req(True, path, 'GET', request_options)
-            if res['status'] == 'published':
-                return res
-            time.sleep(time_before_retry / 1000.0)
+        return self.client.wait_task(self.index_name, task_id, time_before_retry, request_options)
 
     def is_task_published(self, task_id, request_options=None):
-        '''
-        Return True if the task on the server has been published
-
-        @param task_id the id of the task returned by server
-        '''
-
-        path = '/task/{0}'.format(task_id)
-        res = self._req(True, path, 'GET', request_options)
-        return res['status'] == 'published'
+        return self.client.wait_task(self.index_name, task_id, request_options)
 
     @deprecated
     def getSettings(self):