fix(logging): pass user configured logger to temp client (#480)

The `replace_all_objects` command creates a temporary client which does
not have the some configuration as one constructed by users of the
library. This change adds an optional parameter when constructing an
index for the `logger` and allows that to be passed in to the temporary
client. This change also ensures that any `Index` built through the
`SearchClient#init_index` call gets the logger configured on the client.
This will ensure logging is done in a consistent manner across clients
instantiated by the library.

Author: forkata

lib/algolia/search_client.rb

@@ -19,8 +19,8 @@ class Client
       def initialize(search_config, opts = {})
         @config      = search_config
         adapter      = opts[:adapter] || Defaults::ADAPTER
-        logger       = opts[:logger] || LoggerHelper.create
-        requester    = opts[:http_requester] || Defaults::REQUESTER_CLASS.new(adapter, logger)
+        @logger      = opts[:logger] || LoggerHelper.create
+        requester    = opts[:http_requester] || Defaults::REQUESTER_CLASS.new(adapter, @logger)
         @transporter = Transport::Transport.new(@config, requester)
       end
 
@@ -94,7 +94,7 @@ def init_index(index_name)
         if stripped_index_name.empty?
           raise AlgoliaError, 'Please provide a valid index name'
         end
-        Index.new(stripped_index_name, @transporter, @config)
+        Index.new(stripped_index_name, @transporter, @config, @logger)
       end
 
       # List all indexes of the client

lib/algolia/search_index.rb

@@ -5,18 +5,20 @@ class Index
       include CallType
       include Helpers
 
-      attr_reader :name, :transporter, :config
+      attr_reader :name, :transporter, :config, :logger
 
       # Initialize an index
       #
       # @param name [String] name of the index
       # @param transporter [Object] transport object used for the connection
       # @param config [Config] a Config object which contains your APP_ID and API_KEY
+      # @param logger [LoggerHelper] an optional LoggerHelper object to use
       #
-      def initialize(name, transporter, config)
+      def initialize(name, transporter, config, logger = nil)
         @name        = name
         @transporter = transporter
         @config      = config
+        @logger      = logger || LoggerHelper.create
       end
 
       # # # # # # # # # # # # # # # # # # # # #
@@ -830,7 +832,7 @@ def replace_all_objects(objects, opts = {})
         end
 
         # TODO: consider create a new client with state of retry is shared
-        tmp_client = Algolia::Search::Client.new(@config)
+        tmp_client = Algolia::Search::Client.new(@config, { logger: logger })
         tmp_index  = tmp_client.init_index(tmp_index_name)
 
         save_objects_response = tmp_index.save_objects(objects, request_options)