fix(helpers): encode index_name properly (#497)

Author: kombucha

lib/algolia/helpers.rb

@@ -44,7 +44,7 @@ def get_option(hash, key)
   def path_encode(path, *args)
     arguments = []
     args.each do |arg|
-      arguments.push(CGI.escape(CGI.unescape(arg.to_s)))
+      arguments.push(CGI.escape(arg.to_s))
     end
 
     format(path, *arguments)

test/algolia/unit/helpers_test.rb

@@ -40,6 +40,10 @@ def test_deserialize_settings_with_string
       deserialized_settings = deserialize_settings(old_settings, false)
       assert_equal new_settings, deserialized_settings
     end
+
+    def test_path_encode
+      assert_equal path_encode('/1/indexes/%s/settings', 'premium+ some_name'), '/1/indexes/premium%2B+some_name/settings'
+    end
   end
 
   describe 'test hash_includes_subset' do