fix(requests): keep track of all retry errors

Author: Thomas Dalous

lib/algolia/error.rb

@@ -10,6 +10,12 @@ class AlgoliaError < StandardError
   # Used when hosts are unreachable
   #
   class AlgoliaUnreachableHostError < AlgoliaError
+    attr_reader :errors
+
+    def initialize(message, errors = [])
+      super(message)
+      @errors = errors
+    end
   end
 
   # An exception class raised when the REST API returns an error.

lib/algolia/transport/transport.rb

@@ -49,7 +49,7 @@ def write(method, path, body = {}, opts = {})
       # @return [Response] response of the request
       #
       def request(call_type, method, path, body = {}, opts = {})
-        last_retry = {host: nil, error: nil}
+        retry_errors = []
 
         @retry_strategy.get_tryable_hosts(call_type).each do |host|
           opts[:timeout]         ||= get_timeout(call_type) * (host.retry_count + 1)
@@ -76,13 +76,13 @@ def request(call_type, method, path, body = {}, opts = {})
             raise AlgoliaHttpError.new(get_option(decoded_error, 'status'), get_option(decoded_error, 'message'))
           end
           if outcome == RETRY
-            last_retry = {host: host.url, error: response.error}
+            retry_errors << {host: host.url, error: response.error}
           else
             return json_to_hash(response.body, @config.symbolize_keys)
           end
         end
 
-        raise AlgoliaUnreachableHostError, "Unreachable hosts. Last error for #{last_retry[:host]}: #{last_retry[:error]}"
+        raise AlgoliaUnreachableHostError.new("Unreachable hosts. Last error for #{retry_errors.last[:host]}: #{retry_errors.last[:error]}", retry_errors)
       end
 
       private

test/algolia/unit/retry_strategy_test.rb

@@ -73,7 +73,7 @@ def test_resets_all_hosts_when_expired_according_to_write_type
 
   describe 'All hosts are unreachable' do
     def test_failure_when_all_hosts_are_down
-      stateful_hosts = ['0.0.0.0']
+      stateful_hosts = ['0.0.0.0', '1.0.0.0']
       @config        = Algolia::Search::Config.new(application_id: 'foo', api_key: 'bar', custom_hosts: stateful_hosts)
       client         = Algolia::Search::Client.create_with_config(@config)
       index          = client.init_index(get_test_index_name('failure'))
@@ -82,7 +82,11 @@ def test_failure_when_all_hosts_are_down
         index.save_object({ objectID: 'one' })
       end
 
-      assert_includes exception.message, 'Unreachable hosts. Last error for 0.0.0.0: SSL_connect'
+      assert_includes exception.message, 'Unreachable hosts. Last error for 1.0.0.0: SSL_connect'
+      assert_equal exception.errors, [
+        {:host=>"0.0.0.0", :error=>"SSL_connect SYSCALL returned=5 errno=0 peeraddr=127.0.0.1:443 state=error: certificate verify failed"},
+        {:host=>"1.0.0.0", :error=>"SSL_connect returned=1 errno=0 peeraddr=1.0.0.0:443 state=error: ssl/tls alert handshake failure"}
+      ]
     end
   end