fix(helpers): deserialize_settings function (#430)

Author: chloelbn

lib/algolia/helpers.rb

@@ -53,14 +53,15 @@ def path_encode(path, *args)
   # Support to convert old settings to their new names
   #
   def deserialize_settings(data, symbolize_keys)
-    settings = symbolize_hash(data)
+    settings = data
     keys     = {
       attributesToIndex: 'searchableAttributes',
       numericAttributesToIndex: 'numericAttributesForFiltering',
       slaves: 'replicas'
     }
 
     keys.each do |deprecated_key, current_key|
+      deprecated_key = symbolize_keys ? deprecated_key : deprecated_key.to_s
       if settings.has_key?(deprecated_key)
         key           = symbolize_keys ? current_key.to_sym : current_key.to_s
         settings[key] = settings.delete(deprecated_key)

test/algolia/unit/helpers_test.rb

@@ -26,13 +26,15 @@ def test_deserialize_settings_with_string
       old_settings = {
         'attributesToIndex' => %w(attr1 attr2),
         'numericAttributesToIndex' => %w(attr1 attr2),
-        'slaves' => %w(index1 index2)
+        'slaves' => %w(index1 index2),
+        'minWordSizefor1Typo' => 1
       }
 
       new_settings = {
         'searchableAttributes' => %w(attr1 attr2),
         'numericAttributesForFiltering' => %w(attr1 attr2),
-        'replicas' => %w(index1 index2)
+        'replicas' => %w(index1 index2),
+        'minWordSizefor1Typo' => 1
       }
 
       deserialized_settings = deserialize_settings(old_settings, false)