fix(requests): add host to last error

Author: Thomas Dalous

lib/algolia/transport/transport.rb

@@ -49,7 +49,7 @@ def write(method, path, body = {}, opts = {})
       # @return [Response] response of the request
       #
       def request(call_type, method, path, body = {}, opts = {})
-        last_retry_error = nil
+        last_retry = {host: nil, error: nil}
 
         @retry_strategy.get_tryable_hosts(call_type).each do |host|
           opts[:timeout]         ||= get_timeout(call_type) * (host.retry_count + 1)
@@ -76,13 +76,13 @@ def request(call_type, method, path, body = {}, opts = {})
             raise AlgoliaHttpError.new(get_option(decoded_error, 'status'), get_option(decoded_error, 'message'))
           end
           if outcome == RETRY
-            last_retry_error = response.error
+            last_retry = {host: host.url, error: response.error}
           else
             return json_to_hash(response.body, @config.symbolize_keys)
           end
         end
 
-        raise AlgoliaUnreachableHostError, "Unreachable hosts. Last error: #{last_retry_error}"
+        raise AlgoliaUnreachableHostError, "Unreachable hosts. Last error for #{last_retry[:host]}: #{last_retry[:error]}"
       end
 
       private

test/algolia/unit/retry_strategy_test.rb

@@ -82,7 +82,7 @@ def test_failure_when_all_hosts_are_down
         index.save_object({ objectID: 'one' })
       end
 
-      assert_includes exception.message, 'Unreachable hosts. Last error: SSL_connect'
+      assert_includes exception.message, 'Unreachable hosts. Last error for 0.0.0.0: SSL_connect'
     end
   end