Skip to content

Commit dd468cb

Browse files
authored
fix(set-settings): forwardToReplicas param (#451)
* fix(set-settings): forwardTpReplicas param * fix(set-settings): refacto method
1 parent 1fa08e0 commit dd468cb

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

lib/algolia/search_index.rb

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,15 @@ def get_settings(opts = {})
987987
# @return [IndexingResponse]
988988
#
989989
def set_settings(settings, opts = {})
990-
response = @transporter.write(:PUT, path_encode('/1/indexes/%s/settings', @name), settings, opts)
990+
request_options = symbolize_hash(opts)
991+
forward_to_replicas = request_options.delete(:forwardToReplicas) || false
992+
993+
response = @transporter.write(
994+
:PUT,
995+
path_encode('/1/indexes/%s/settings', @name) + handle_params({ forwardToReplicas: forward_to_replicas }),
996+
settings,
997+
request_options
998+
)
991999

9921000
IndexingResponse.new(self, response)
9931001
end

test/algolia/integration/search_index_test.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,9 @@ def test_settings
274274
@index.set_settings!(settings)
275275

276276
assert_equal @index.get_settings, settings
277+
278+
# check that the forwardToReplicas parameter is passed correctly
279+
assert @index.set_settings!(settings, { forwardToReplicas: true })
277280
end
278281
end
279282

0 commit comments

Comments
 (0)