Add unique identifiers for indices in Analytics integration tests to avoid flakiness

Author: VladislavFitz

Tests/AlgoliaSearchClientTests/Integration/AnalyticsIntegrationsTests.swift

@@ -25,11 +25,11 @@ class AnalyticsIntegrationTests: OnlineTestCase {
   }
 
   func abTesting() throws {
-    
+        
     let analyticsClient = AnalyticsClient(appID: client.applicationID, apiKey: client.apiKey)
 
-    let index1 = client.index(withName: "ab_testing")
-    let index2 = client.index(withName: "ab_testing_dev")
+    let index1 = client.index(withName: IndexName(rawValue: "\(uniquePrefix())_ab_testing"))
+    let index2 = client.index(withName: IndexName(rawValue:"\(uniquePrefix())_ab_testing_dev"))
 
     let save1 = try index1.saveObject(["objectID": "one"] as JSON)
     try AssertWait(save1)
@@ -71,7 +71,7 @@ class AnalyticsIntegrationTests: OnlineTestCase {
   func aaTesting() throws {
 
     let analyticsClient = AnalyticsClient(appID: client.applicationID, apiKey: client.apiKey)
-    let index = client.index(withName: "aa_testing")
+    let index = client.index(withName: IndexName(rawValue: "\(uniquePrefix())_aa_testing"))
 
     let saveObject = try index.saveObject(["objectID": "one"])
     try AssertWait(saveObject)

Tests/AlgoliaSearchClientTests/Integration/OnlineTestCase.swift

@@ -26,6 +26,13 @@ class OnlineTestCase: XCTestCase {
   var indexNameSuffix: String? {
     return nil
   }
+  
+  func uniquePrefix() -> String {
+    let dateFormatter = DateFormatter()
+    dateFormatter.dateFormat = "YYYY-MM-DD_HH:mm:ss"
+    let dateString = dateFormatter.string(from: .init())
+    return "swift_\(dateString)_\(NSUserName().description)"
+  }
 
   override func setUpWithError() throws {
 
@@ -36,14 +43,10 @@ class OnlineTestCase: XCTestCase {
     }
 
     client = SearchClient(appID: credentials.applicationID, apiKey: credentials.apiKey)
-    
     let className = String(reflecting: type(of: self)).components(separatedBy: ".").last!
     let functionName = invocation!.selector.description
     let indexNameSuffix = self.indexNameSuffix ?? "\(className).\(functionName)"
-    let dateFormatter = DateFormatter()
-    dateFormatter.dateFormat = "YYYY-MM-DD_HH:mm:ss"
-    let dateString = dateFormatter.string(from: .init())
-    let indexName = IndexName(stringLiteral: "swift_\(dateString)_\(NSUserName().description)_\(indexNameSuffix)")
+    let indexName = IndexName(stringLiteral: "\(uniquePrefix())_\(indexNameSuffix)")
     index = client.index(withName: indexName)
 
     try index.delete()