Skip to content

Commit d8452c9

Browse files
fix(SearchParameters): set correct coding key for sortFacetsBy (#674)
* Set correct coding key for sortFacetsBy * Fix Query unit test * Fix Query rule coding test
1 parent e281978 commit d8452c9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Sources/AlgoliaSearchClient/Models/Search/Query/Query+Codable.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ extension Query: Codable {
167167
case facets
168168
case maxValuesPerFacet
169169
case facetingAfterDistinct
170-
case sortFacetsBy
170+
case sortFacetsBy = "sortFacetValuesBy"
171171
case attributesToHighlight
172172
case attributesToSnippet
173173
case highlightPreTag

Tests/AlgoliaSearchClientTests/Unit/QueryTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class QueryTests: XCTestCase {
102102
"facets=facet1,facet2,facet3",
103103
"maxValuesPerFacet=10",
104104
"facetingAfterDistinct=true",
105-
"sortFacetsBy=count",
105+
"sortFacetValuesBy=count",
106106
"maxFacetHits=100",
107107
"attributesToHighlight=hattr1,hattr2,hattr3",
108108
"attributesToSnippet=sattr1:10,sattr2",
@@ -193,7 +193,7 @@ class QueryTests: XCTestCase {
193193
"sumOrFiltersScores": false,
194194
"maxValuesPerFacet": 10,
195195
"facetingAfterDistinct": true,
196-
"sortFacetsBy": "count",
196+
"sortFacetValuesBy": "count",
197197
"maxFacetHits": 100,
198198
"attributesToHighlight": ["hattr1", "hattr2", "hattr3"],
199199
"attributesToSnippet": ["sattr1:10", "sattr2"],

Tests/AlgoliaSearchClientTests/Unit/Rule/RuleConsequenceTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class RuleConsequenceTests: XCTestCase {
2626

2727
try AssertEncodeDecode(consequence, [
2828
"params": [
29-
"sortFacetsBy": "alpha",
29+
"sortFacetValuesBy": "alpha",
3030
"filters": "filter:value",
3131
"automaticFacetFilters": [["facet": "attr", "score": 10, "disjunctive": true]],
3232
"automaticOptionalFacetFilters": [["facet": "attr2", "score": 20, "disjunctive": false]],

0 commit comments

Comments
 (0)