fix: django settings upgrade and some cleanup

Author: shortcuts

algoliasearch_django/models.py

@@ -86,12 +86,9 @@ def __init__(self, model, client, settings):
         ):  # Only set settings if the actual index class does not define some
             self.settings = {}
 
-        try:
-            all_model_fields = [
-                f.name for f in model._meta.get_fields() if not f.is_relation
-            ]
-        except AttributeError:  # get_fields requires Django >= 1.8
-            all_model_fields = [f.name for f in model._meta.local_fields]
+        all_model_fields = [
+            f.name for f in model._meta.get_fields() if not f.is_relation
+        ]
 
         if isinstance(self.fields, str):
             self.fields = (self.fields,)
@@ -324,7 +321,6 @@ def save_record(self, instance, update_fields=None, **kwargs):
                 )
             else:
                 obj = self.get_raw_record(instance)
-                print(obj)
                 self.__client.save_objects(
                     index_name=self.index_name, objects=[obj], wait_for_tasks=True
                 )

runtests.py

@@ -12,8 +12,10 @@ def main():
     os.environ["DJANGO_SETTINGS_MODULE"] = "tests.settings"
     django.setup()
     TestRunner = get_runner(settings)
-    test_runner = TestRunner()
-    failures = test_runner.run_tests(["tests"])
+    test_runner = TestRunner(failfase=True)
+    # kept here to run a single test
+    failures = test_runner.run_tests(["tests.test_index.IndexTestCase"])
+    # failures = test_runner.run_tests(["tests"])
     sys.exit(bool(failures))
 
 

tests/settings.py

@@ -1,25 +1,36 @@
 """
 Django settings for core project.
 
-Generated by 'django-admin startproject' using Django 1.8.2.
+Generated by 'django-admin startproject' using Django 5.1.3.
 
 For more information on this file, see
-https://docs.djangoproject.com/en/1.8/topics/settings/
+https://docs.djangoproject.com/en/5.1/topics/settings/
 
 For the full list of settings and their values, see
-https://docs.djangoproject.com/en/1.8/ref/settings/
+https://docs.djangoproject.com/en/5.1/ref/settings/
 """
 
 import os
 import time
+from pathlib import Path
 
+# Build paths inside the project like this: BASE_DIR / 'subdir'.
+BASE_DIR = Path(__file__).resolve().parent.parent
 
-BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
+# Quick-start development settings - unsuitable for production
+# See https://docs.djangoproject.com/en/5.1/howto/deployment/checklist/
+
+# SECURITY WARNING: keep the secret key used in production secret!
 SECRET_KEY = "MillisecondsMatter"
-DEBUG = False
+
+# SECURITY WARNING: don't run with debug turned on in production!
+DEBUG = True
+
+ALLOWED_HOSTS = []
 
 # Application definition
-INSTALLED_APPS = (
+
+INSTALLED_APPS = [
     "django.contrib.admin",
     "django.contrib.auth",
     "django.contrib.contenttypes",
@@ -28,19 +39,21 @@
     "django.contrib.staticfiles",
     "algoliasearch_django",
     "tests",
-)
+]
 
 MIDDLEWARE = [
-    "django.contrib.sessions.middleware.SessionMiddleware",
-    "django.middleware.common.CommonMiddleware",
-    "django.middleware.csrf.CsrfViewMiddleware",
     "django.contrib.auth.middleware.AuthenticationMiddleware",
     "django.contrib.auth.middleware.SessionAuthenticationMiddleware",
     "django.contrib.messages.middleware.MessageMiddleware",
+    "django.contrib.sessions.middleware.SessionMiddleware",
     "django.middleware.clickjacking.XFrameOptionsMiddleware",
+    "django.middleware.common.CommonMiddleware",
+    "django.middleware.csrf.CsrfViewMiddleware",
     "django.middleware.security.SecurityMiddleware",
 ]
 
+ROOT_URLCONF = "tests.urls"
+
 TEMPLATES = [
     {
         "BACKEND": "django.template.backends.django.DjangoTemplates",
@@ -57,23 +70,34 @@
     },
 ]
 
-ROOT_URLCONF = "tests.urls"
-
 # Database
+# https://docs.djangoproject.com/en/5.1/ref/settings/#databases
+
 DATABASES = {
     "default": {
         "ENGINE": "django.db.backends.sqlite3",
-        "NAME": os.path.join(BASE_DIR, "db.sqlite3"),
+        "NAME": BASE_DIR / "db.sqlite3",
     }
 }
 
 # Internationalization
+# https://docs.djangoproject.com/en/5.1/topics/i18n/
+
 LANGUAGE_CODE = "en-us"
+
 TIME_ZONE = "UTC"
+
 USE_I18N = True
+
 USE_L10N = True
+
 USE_TZ = True
 
+# Default primary key field type
+# https://docs.djangoproject.com/en/5.1/ref/settings/#default-auto-field
+
+DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
+
 
 def safe_index_name(name):
     return "{}_ci-{}".format(name, time.time())

tests/test_index.py

@@ -23,6 +23,7 @@ def setUp(self):
             _lng=-42.24,
             _permissions="read,write,admin",
         )
+        self.website = Website(name="Algolia", url="https://algolia.com")
 
         self.contributor = User(
             name="Contributor",
@@ -675,12 +676,10 @@ class ExampleIndex3(AlgoliaIndex):
             self.index._should_index(self.example)
 
     def test_save_record_should_index_boolean(self):
-        website = Website(name="Algolia", url="https://algolia.com", is_online=True)
         self.index = AlgoliaIndex(Website, self.client, settings.ALGOLIA)
 
         class WebsiteIndex(AlgoliaIndex):
-            self.assertIsNotNone(self.index.index_name)
-
+            custom_objectID = "name"
             settings = {
                 "replicas": [
                     self.index.index_name + "_name_asc",  # pyright: ignore
@@ -689,8 +688,9 @@ class WebsiteIndex(AlgoliaIndex):
             }
             should_index = "is_online"
 
+        self.website.is_online = True
         self.index = WebsiteIndex(Website, self.client, settings.ALGOLIA)
-        self.index.save_record(website)
+        self.index.save_record(self.website)
 
     def test_cyrillic(self):
         class CyrillicIndex(AlgoliaIndex):