Skip to content

Commit bf1072d

Browse files
authored
Fix/default log handler (#248)
* chore: bump version to 1.5.5 * fix(test_signal): Increase delay to 10s to avoid race condition, with FIXME * fix: Define default log handler
1 parent 42638e0 commit bf1072d

File tree

4 files changed

+19
-4
lines changed

4 files changed

+19
-4
lines changed

ChangeLog

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11

22
CHANGELOG
3+
2018-02-14 1.5.5
4+
* [FIX] Settings no more shared across AlgoliaIndex instances
5+
* [FIX] Save rules and synonyms over reindex
6+
37
2018-01-16 1.5.4
48
* Shallow release to solve 1.5.3 release issue
59

algoliasearch_django/__init__.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,14 @@
3030
raw_search = algolia_engine.raw_search
3131
clear_index = algolia_engine.clear_index
3232
reindex_all = algolia_engine.reindex_all
33+
34+
# Default log handler
35+
import logging
36+
37+
38+
class NullHandler(logging.Handler):
39+
def emit(self, record):
40+
pass
41+
42+
43+
logging.getLogger(__name__.split('.')[0]).addHandler(NullHandler())

algoliasearch_django/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
VERSION = '1.5.4'
1+
VERSION = '1.5.5'

tests/test_signal.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def test_save_signal(self):
3131
Website.objects.create(name='Google', url='https://www.google.com')
3232
Website.objects.create(name='Facebook', url='https://www.facebook.com')
3333

34-
time.sleep(5)
34+
time.sleep(10) # FIXME: Expose last task's ID so we can waitTask instead of sleeping
3535
self.assertEqual(raw_search(Website)['nbHits'], 3)
3636

3737
def test_delete_signal(self):
@@ -42,7 +42,7 @@ def test_delete_signal(self):
4242
Website.objects.get(name='Algolia').delete()
4343
Website.objects.get(name='Facebook').delete()
4444

45-
time.sleep(5)
45+
time.sleep(10)
4646
result = raw_search(Website)
4747
self.assertEqual(result['nbHits'], 1)
4848
self.assertEqual(result['hits'][0]['name'], 'Google')
@@ -58,7 +58,7 @@ def test_update_records(self):
5858
update_records(Website, qs, url='https://facebook.com')
5959
qs.update(url='https://facebook.com')
6060

61-
time.sleep(5)
61+
time.sleep(10)
6262
result = raw_search(Website, 'Facebook')
6363
self.assertEqual(result['nbHits'], qs.count())
6464
for res, url in zip(result['hits'], qs.values_list('url', flat=True)):

0 commit comments

Comments
 (0)