MAGE-1151: refactor data colunm formatting

Author: damcou

Ui/Component/Listing/Column/Data.php

@@ -4,6 +4,9 @@
 
 class Data extends \Magento\Ui\Component\Listing\Columns\Column
 {
+
+    const MAX_DEPTH_DISPLAY = 3;
+
     /**
      * @param array $dataSource
      *
@@ -23,27 +26,37 @@ public function prepareDataSource(array $dataSource)
 
         foreach ($dataSource['data']['items'] as &$item) {
             $data = json_decode($item[$fieldName], true);
-            $formattedData = '';
-            if (is_array($data)) {
-                foreach ($data as $key => $value) {
-                    if (is_array($value)) {
-                        $stringValue = '';
-                        foreach ($value as $k => $v) {
-                            if (is_string($k)) {
-                                $v = !is_array($v) ? $v : implode(",", $v);
-                                $stringValue .= '<br>&nbsp;&nbsp;&nbsp; - <strong>' . $k . '</strong> : '. $v;
-                            } else {
-                                $stringValue .= $v . ',';
-                            }
-                        }
-                        $value = rtrim($stringValue,",");
-                    }
-                    $formattedData .= '- <strong>' .$key . '</strong> : ' . $value . '<br>';
+            $item[$fieldName] = is_array($data) ? $this->formatData($data) : '';;
+        }
+
+        return $dataSource;
+    }
+
+    protected function formatData(array $data, $depth = 0): string
+    {
+        if ($depth > self::MAX_DEPTH_DISPLAY) {
+            return '';
+        }
+
+        $formattedData = '';
+
+        foreach ($data as $key => $value) {
+            $stringKey = '- <strong>' . $key . '</strong>';
+
+            if (is_array($value)) {
+                if ($key === 'entityIds') {
+                    $formattedData .=
+                        str_repeat('&nbsp;&nbsp;&nbsp;', $depth ) . $stringKey . ' : '  . implode(', ', $value) . '<br>';
+                } else {
+                    $formattedData .= $stringKey . ' :<br>'  . $this->formatData($value, ++$depth);
                 }
+
+                continue;
             }
-            $item[$fieldName] = $formattedData;
+
+            $formattedData .= str_repeat('&nbsp;&nbsp;&nbsp;', $depth ) . $stringKey . ' : ' . $value . '<br>';
         }
 
-        return $dataSource;
+        return $formattedData;
     }
 }