MAGE-1281 Move lingering IS confg to discrete helper

Author: cammonro

Helper/ConfigHelper.php

@@ -308,7 +308,7 @@ public function getAlgoliaCookieDuration($storeId = null)
     }
 
     // --- Products --- //
-    
+
     /**
      * @param $storeId
      * @return array
@@ -2038,15 +2038,12 @@ public function isInstantSearchBoxEnabled($storeId = null)
     /**
      * @param $storeId
      * @return bool
-     * @deprecated This method will be moved to the InstantSearch config helper
+     * @deprecated This method has been moved to the InstantSearch config helper and will be removed in a future version
+     * @see \Algolia\AlgoliaSearch\Helper\Configuration\InstantSearchHelper::shouldShowSuggestionsOnNoResultsPage()
      */
     public function showSuggestionsOnNoResultsPage($storeId = null)
     {
-        return $this->configInterface->isSetFlag(
-            self::SHOW_SUGGESTIONS_NO_RESULTS,
-            ScopeInterface::SCOPE_STORE,
-            $storeId
-        );
+        return $this->instantSearchConfig->shouldShowSuggestionsOnNoResultsPage($storeId);
     }
 
     /**

Helper/Configuration/InstantSearchHelper.php

@@ -132,6 +132,15 @@ public function setSorting(
         );
     }
 
+    public function shouldShowSuggestionsOnNoResultsPage(?int $storeId = null): bool
+    {
+        return $this->configInterface->isSetFlag(
+            self::SHOW_SUGGESTIONS_NO_RESULTS,
+            ScopeInterface::SCOPE_STORE,
+            $storeId
+        );
+    }
+
     public function isSearchBoxEnabled(?int $storeId = null): bool
     {
         return $this->isEnabled($storeId)