MAGE-1201 Check CLI context for warnings

cammonro · cammonro · commit 269a880a5566 · 2025-05-06T14:16:53.000-04:00
diff --git a/Observer/RecommendSettings.php b/Observer/RecommendSettings.php
@@ -207,7 +207,7 @@ protected function handleRecommendApiException(\Exception $e, string $modelName,
         }
 
         $msg = __(
-            "The following error was encountered while enabling %1 recommendations: %2",
+            "Error encountered while enabling %1 recommendations: %2",
             $modelName,
             $msg
         );
@@ -237,8 +237,8 @@ protected function rollBack(string $changedPath, \Magento\Framework\Phrase $mess
      */
     protected function shouldDisplayWarning(): bool
     {
-        return $this->appState->getAreaCode() === \Magento\Framework\App\Area::AREA_ADMINHTML;
-
+        return $this->appState->getAreaCode() === \Magento\Framework\App\Area::AREA_ADMINHTML
+            && php_sapi_name() !== 'cli';
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ protected function handleRecommendApiException(\Exception $e, string $modelName,`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`$msg = __(`
`210`		`- "The following error was encountered while enabling %1 recommendations: %2",`
	`210`	`+ "Error encountered while enabling %1 recommendations: %2",`
`211`	`211`	`$modelName,`
`212`	`212`	`$msg`
`213`	`213`	`);`
`@@ -237,8 +237,8 @@ protected function rollBack(string $changedPath, \Magento\Framework\Phrase $mess`
`237`	`237`	`*/`
`238`	`238`	`protected function shouldDisplayWarning(): bool`
`239`	`239`	`{`
`240`		`- return $this->appState->getAreaCode() === \Magento\Framework\App\Area::AREA_ADMINHTML;`
`241`		`-`
	`240`	`+ return $this->appState->getAreaCode() === \Magento\Framework\App\Area::AREA_ADMINHTML`
	`241`	`+ && php_sapi_name() !== 'cli';`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`/**`