MAGE-940: code updated as per code review suggestions

Author: mrahman3177

Model/RecommendManagement.php

@@ -14,21 +14,21 @@ class RecommendManagement implements RecommendManagementInterface
     /**
      * @var null|RecommendClient
      */
-    private ?RecommendClient $client = null;
+    protected ?RecommendClient $client = null;
 
     /**
      * @param ConfigHelper $configHelper
      * @param IndexNameFetcher $indexNameFetcher
      */
     public function __construct(
-        private readonly ConfigHelper          $configHelper,
-        private readonly IndexNameFetcher      $indexNameFetcher
+        protected readonly ConfigHelper          $configHelper,
+        protected readonly IndexNameFetcher      $indexNameFetcher
     ){}
 
     /**
      * @return RecommendClient
      */
-    private function getClient(): RecommendClient
+    protected function getClient(): RecommendClient
     {
         if ($this->client === null) {
             $this->client = RecommendClient::create(
@@ -85,7 +85,7 @@ public function getLookingSimilarRecommendation(string $productId): array
      * @return array
      * @throws NoSuchEntityException
      */
-    private function getRecommendations(string $productId, string $model, float|int $threshold = 50): array
+    protected function getRecommendations(string $productId, string $model, float|int $threshold = 50): array
     {
         $request['indexName'] = $this->indexNameFetcher->getIndexName('_products');
         $request['model'] = $model;

Observer/RecommendSettings.php

@@ -14,10 +14,14 @@
 
 class RecommendSettings implements ObserverInterface
 {
+    const QUANTITY_AND_STOCK_STATUS = 'quantity_and_stock_status';
+    const STATUS = 'status';
+    const VISIBILITY = 'visibility';
+
     /**
      * @var string
      */
-    private $productId = '';
+    protected $productId = '';
 
     /**
      * @param ConfigHelper $configHelper
@@ -27,11 +31,11 @@ class RecommendSettings implements ObserverInterface
      * @param SearchCriteriaBuilder $searchCriteriaBuilder
      */
     public function __construct(
-        private readonly ConfigHelper                 $configHelper,
-        private readonly WriterInterface              $configWriter,
-        private readonly ProductRepositoryInterface   $productRepository,
-        private readonly RecommendManagementInterface $recommendManagement,
-        private readonly SearchCriteriaBuilder        $searchCriteriaBuilder
+        protected readonly ConfigHelper                 $configHelper,
+        protected readonly WriterInterface              $configWriter,
+        protected readonly ProductRepositoryInterface   $productRepository,
+        protected readonly RecommendManagementInterface $recommendManagement,
+        protected readonly SearchCriteriaBuilder        $searchCriteriaBuilder
     ){}
 
     /**
@@ -119,7 +123,7 @@ protected function validateRelatedProducts(string $changedPath): void
             $recommendations = $this->recommendManagement->getRelatedProductsRecommendation($this->getProductId());
             if (empty($recommendations['renderingContent'])) {
                 throw new LocalizedException(__(
-                    "It appears that there is no trained model available for the AppID: %1.",
+                    "It appears that there is no trained model available for Algolia application ID: %1.",
                     $this->configHelper->getApplicationID()
                 ));
             }
@@ -141,7 +145,7 @@ protected function validateTrendingItems(string $changedPath): void
             // When no recommendations suggested, most likely trained model is missing
             if (empty($recommendations['renderingContent'])) {
                 throw new LocalizedException(__(
-                    "It appears that there is no trained model available for the AppID: %1.",
+                    "It appears that there is no trained model available for Algolia application ID: %1.",
                     $this->configHelper->getApplicationID()
                 ));
             }
@@ -162,7 +166,7 @@ protected function validateLookingSimilar(string $changedPath): void
             $recommendations = $this->recommendManagement->getLookingSimilarRecommendation($this->getProductId());
             if (empty($recommendations['renderingContent'])) {
                 throw new LocalizedException(__(
-                    "It appears that there is no trained model available for the AppID: %1.",
+                    "It appears that there is no trained model available for Algolia application ID: %1.",
                     $this->configHelper->getApplicationID()
                 ));
             }
@@ -175,13 +179,13 @@ protected function validateLookingSimilar(string $changedPath): void
     /**
      * @return string
      */
-    private function getProductId(): string
+    protected function getProductId(): string
     {
         if ($this->productId === '') {
             $searchCriteria = $this->searchCriteriaBuilder
-                ->addFilter('status', 1)
-                ->addFilter('quantity_and_stock_status', 1)
-                ->addFilter('visibility', [2, 3, 4], 'in')
+                ->addFilter(self::STATUS, 1)
+                ->addFilter(self::QUANTITY_AND_STOCK_STATUS, 1)
+                ->addFilter(self::VISIBILITY, [2, 3, 4], 'in')
                 ->setPageSize(10)
                 ->create();
             $result = $this->productRepository->getList($searchCriteria);