MAGE-1383 Add data provider for more scenarios

Author: cammonro

Test/Unit/Helper/ArrayDeduplicatorTest.php

@@ -14,19 +14,109 @@ protected function setUp(): void
         $this->deduplicator = new ArrayDeduplicator();
     }
 
-    public function testDedupeArrayOfArraysRemovesExactDuplicates(): void
+    public static function dedupeArrayOfArraysProvider(): array
     {
-        $data = [
-            ['a' => 1, 'b' => 2],
-            ['a' => 1, 'b' => 2], // duplicate
-            ['a' => 2, 'b' => 3],
+        return [
+            'empty array' => [
+                'input' => [],
+                'expectedCount' => 0,
+                'expectedItems' => []
+            ],
+            'no duplicates' => [
+                'input' => [
+                    ['a' => 1, 'b' => 2],
+                    ['a' => 2, 'b' => 3],
+                    ['a' => 3, 'b' => 4]
+                ],
+                'expectedCount' => 3,
+                'expectedItems' => [
+                    ['a' => 1, 'b' => 2],
+                    ['a' => 2, 'b' => 3],
+                    ['a' => 3, 'b' => 4]
+                ]
+            ],
+            'exact duplicates' => [
+                'input' => [
+                    ['a' => 1, 'b' => 2],
+                    ['a' => 1, 'b' => 2], // duplicate
+                    ['a' => 2, 'b' => 3]
+                ],
+                'expectedCount' => 2,
+                'expectedItems' => [
+                    ['a' => 1, 'b' => 2],
+                    ['a' => 2, 'b' => 3]
+                ]
+            ],
+            'multiple duplicates' => [
+                'input' => [
+                    ['id' => 1, 'name' => 'test'],
+                    ['id' => 2, 'name' => 'test2'],
+                    ['id' => 1, 'name' => 'test'], // duplicate
+                    ['id' => 3, 'name' => 'test3'],
+                    ['id' => 2, 'name' => 'test2'] // duplicate
+                ],
+                'expectedCount' => 3,
+                'expectedItems' => [
+                    ['id' => 1, 'name' => 'test'],
+                    ['id' => 2, 'name' => 'test2'],
+                    ['id' => 3, 'name' => 'test3']
+                ]
+            ],
+            'duplicate synonyms' => [
+                'input' => [
+                    ['gray', 'grey'],
+                    ['trousers', 'pants'],
+                    ['ipad', 'tablet'],
+                    ['caulk', 'caulking'],
+                    ['trousers', 'pants'], // duplicate
+                    ['molding', 'moldings', 'moulding', 'mouldings'],
+                    ['trash', 'garbage'],
+                    ['molding', 'moldings', 'moulding', 'mouldings'], // duplicate
+                ],
+                'expectedCount' => 6,
+                'expectedItems' => [
+                    ['gray', 'grey'],
+                    ['trousers', 'pants'],
+                    ['ipad', 'tablet'],
+                    ['caulk', 'caulking'],
+                    ['molding', 'moldings', 'moulding', 'mouldings'],
+                    ['trash', 'garbage'],
+                ]
+            ],
+            'duplicate alt corrections' => [
+                'input' => [
+                    [ 'word' => 'trousers', 'nbTypos' => 1, 'correction' => 'pants' ],
+                    [ 'word' => 'rod', 'nbTypos' => 1, 'correction' => 'bar' ],
+                    [ 'word' => 'bell', 'nbTypos' => 1, 'correction' => 'buzzer' ],
+                    [ 'word' => 'rod', 'nbTypos' => 1, 'correction' => 'bar' ], // duplicate
+                    [ 'word' => 'blind', 'nbTypos' => 1, 'correction' => 'shade' ],
+                    [ 'word' => 'blind', 'nbTypos' => 2, 'correction' => 'shade' ], // not a duplicate
+                    [ 'word' => 'trousers', 'nbTypos' => 1, 'correction' => 'pants' ], // duplicate
+                ],
+                'expectedCount' => 5,
+                'expectedItems' => [
+                    [ 'word' => 'trousers', 'nbTypos' => 1, 'correction' => 'pants' ],
+                    [ 'word' => 'rod', 'nbTypos' => 1, 'correction' => 'bar' ],
+                    [ 'word' => 'bell', 'nbTypos' => 1, 'correction' => 'buzzer' ],
+                    [ 'word' => 'blind', 'nbTypos' => 1, 'correction' => 'shade' ],
+                    [ 'word' => 'blind', 'nbTypos' => 2, 'correction' => 'shade' ],
+                ]
+            ]
         ];
+    }
 
-        $result = $this->deduplicator->dedupeArrayOfArrays($data);
+    /**
+     * @dataProvider dedupeArrayOfArraysProvider
+     */
+    public function testDedupeArrayOfArrays(array $input, int $expectedCount, array $expectedItems): void
+    {
+        $result = $this->deduplicator->dedupeArrayOfArrays($input);
+
+        $this->assertCount($expectedCount, $result);
 
-        $this->assertCount(2, $result);
-        $this->assertContains(['a' => 1, 'b' => 2], $result);
-        $this->assertContains(['a' => 2, 'b' => 3], $result);
+        foreach ($expectedItems as $expectedItem) {
+            $this->assertContains($expectedItem, $result);
+        }
     }
 
     public function testDedupeArrayOfArraysKeepsOrderOfFirstOccurrences(): void
@@ -46,14 +136,14 @@ public function testDedupeSpecificSettingsOnlyProcessesRequestedSettings(): void
     {
         $settings = [
             'synonyms' => [
-                ['word' => 'foo'],
-                ['word' => 'foo'],
+                ['red' => 'rouge'],
+                ['red' => 'rouge'],
             ],
             'altCorrections' => [
-                ['word' => 'bar'],
+                [ 'word' => 'bell', 'nbTypos' => 1, 'correction' => 'buzzer' ],
             ],
-            'placeholders' => [
-                ['word' => 'baz'],
+            'placeholder' => [
+                ['foo' => 'bar'],
             ],
         ];
 
@@ -72,7 +162,7 @@ public function testDedupeSpecificSettingsOnlyProcessesRequestedSettings(): void
     public function testDedupeSpecificSettingsHandlesMissingKeys(): void
     {
         $settings = [
-            'synonyms' => [['w' => 'x']],
+            'synonyms' => [['red', 'rouge']],
         ];
 
         $result = $this->deduplicator->dedupeSpecificSettings(