Revert "MAGE-1244: fix logic"

This reverts commit fe556cc.

Author: damcou

Model/Indexer/Category.php

@@ -12,8 +12,6 @@
  */
 class Category implements \Magento\Framework\Indexer\ActionInterface, \Magento\Framework\Mview\ActionInterface
 {
-    public static $affectedProductIds = [];
-
     public function __construct(
         protected StoreManagerInterface $storeManager,
         protected ConfigHelper $configHelper,
@@ -43,9 +41,6 @@ public function executeList(array $ids)
 
     public function executeRow($id)
     {
-        if (count(self::$affectedProductIds)) {
-            $this->categoryBatchQueueProcessor->setAffectedProductIds(self::$affectedProductIds);
-        }
         $this->execute([$id]);
     }
 }

Service/Category/BatchQueueProcessor.php

@@ -11,12 +11,11 @@
 use Algolia\AlgoliaSearch\Service\AlgoliaCredentialsManager;
 use Algolia\AlgoliaSearch\Service\Category\IndexBuilder as CategoryIndexBuilder;
 use Algolia\AlgoliaSearch\Service\Product\IndexBuilder as ProductIndexBuilder;
-use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Exception\NoSuchEntityException;
 
 class BatchQueueProcessor implements BatchQueueProcessorInterface
 {
-    public $affectedProductIds = [];
+    public static $affectedProductIds = [];
 
     public function __construct(
         protected Data $dataHelper,
@@ -30,7 +29,7 @@ public function __construct(
      * @param int $storeId
      * @param array|null $entityIds
      * @return void
-     * @throws NoSuchEntityException|LocalizedException
+     * @throws NoSuchEntityException
      */
     public function processBatch(int $storeId, ?array $entityIds = null): void
     {
@@ -44,9 +43,7 @@ public function processBatch(int $storeId, ?array $entityIds = null): void
             return;
         }
 
-        if (count($this->affectedProductIds) > 0) {
-            $this->rebuildAffectedProducts($storeId);
-        }
+        $this->rebuildAffectedProducts($storeId);
 
         $categoriesPerPage = $this->configHelper->getNumberOfElementByPage();
 
@@ -62,11 +59,14 @@ public function processBatch(int $storeId, ?array $entityIds = null): void
     /**
      * @param int $storeId
      */
-    protected function rebuildAffectedProducts(int $storeId): void
+    protected function rebuildAffectedProducts($storeId)
     {
-        if ($this->configHelper->indexProductOnCategoryProductsUpdate($storeId)) {
+        $affectedProducts = self::$affectedProductIds;
+        $affectedProductsCount = count($affectedProducts);
+
+        if ($affectedProductsCount > 0 && $this->configHelper->indexProductOnCategoryProductsUpdate($storeId)) {
             $productsPerPage = $this->configHelper->getNumberOfElementByPage();
-            foreach (array_chunk($this->affectedProductIds, $productsPerPage) as $chunk) {
+            foreach (array_chunk($affectedProducts, $productsPerPage) as $chunk) {
                 /** @uses ProductIndexBuilder::buildIndexList() */
                 $this->queue->addToQueue(
                     ProductIndexBuilder::class,
@@ -86,7 +86,7 @@ protected function rebuildAffectedProducts(int $storeId): void
      * @param int $categoriesPerPage
      * @param int $storeId
      */
-    protected function processSpecificCategories(array $categoryIds, int $categoriesPerPage, int $storeId): void
+    protected function processSpecificCategories($categoryIds, $categoriesPerPage, $storeId)
     {
         foreach (array_chunk($categoryIds, $categoriesPerPage) as $chunk) {
             /** @uses CategoryIndexBuilder::buildIndexList */
@@ -106,10 +106,10 @@ protected function processSpecificCategories(array $categoryIds, int $categories
      * @param int $storeId
      * @param int $categoriesPerPage
      *
-     * @throws NoSuchEntityException
-     * @throws LocalizedException
+     * @throws Magento\Framework\Exception\LocalizedException
+     * @throws Magento\Framework\Exception\NoSuchEntityException
      */
-    protected function processFullReindex(int $storeId, int $categoriesPerPage): void
+    protected function processFullReindex($storeId, $categoriesPerPage)
     {
         /** @uses IndicesConfigurator::saveConfigurationToAlgolia() */
         $this->queue->addToQueue(IndicesConfigurator::class, 'saveConfigurationToAlgolia', ['storeId' => $storeId]);
@@ -138,13 +138,4 @@ protected function processFullReindex(int $storeId, int $categoriesPerPage): voi
             );
         }
     }
-
-    /**
-     * @param array $affectedProductIds
-     * @return void
-     */
-    public function setAffectedProductIds(array $affectedProductIds): void
-    {
-        $this->affectedProductIds = $affectedProductIds;
-    }
 }