Skip to content

Commit 45e32c1

Browse files
committed
MAGE-1270: changes after review
1 parent 544bf1d commit 45e32c1

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

Helper/ConfigHelper.php

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1715,6 +1715,15 @@ public function isQueueIndexerEnabled(): bool
17151715
*/
17161716
public const LEGACY_USE_VIRTUAL_REPLICA_ENABLED = 'algoliasearch_instant/instant/use_virtual_replica';
17171717

1718+
// --- Indexing Manager --- //
1719+
1720+
/**
1721+
* @deprecated This constant has been renamed to be more meaningful and to avoid confusion with "backend rendering" statements
1722+
* @see \Algolia\AlgoliaSearch\Helper\ConfigHelper::ENABLE_INDEXING
1723+
*/
1724+
public const ENABLE_BACKEND = self::ENABLE_INDEXING;
1725+
1726+
17181727
// --- Autocomplete --- //
17191728

17201729
/**
@@ -2035,4 +2044,17 @@ public function hidePaginationInInstantSearchPage($storeId = null)
20352044
{
20362045
return $this->instantSearchConfig->shouldHidePagination($storeId);
20372046
}
2047+
2048+
// --- Indexing Manager --- //
2049+
2050+
/**
2051+
* @param $storeId
2052+
* @return bool
2053+
* @deprecated This method has been renamed to be more meaningful and to avoid confusion with "backend rendering" statements
2054+
* @see \Algolia\AlgoliaSearch\Helper\ConfigHelper::isIndexingEnabled()
2055+
*/
2056+
public function isEnabledBackend($storeId = null)
2057+
{
2058+
return $this->isIndexingEnabled($storeId);
2059+
}
20382060
}

view/adminhtml/web/js/config.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ require(
3939
pageWarning += '</div>';
4040

4141
let pageWarningSynonyms = '<div class="algolia_dashboard_warning algolia_dashboard_warning_page">';
42+
pageWarningSynonyms += '<p>Configurations related to indexing have been moved to the "Indexing Manager" section.</p>';
4243
pageWarningSynonyms += '<p>Configurations related to Synonyms have been removed from the Magento dashboard. We advise you to configure synonyms from the Algolia dashboard.</p>';
4344
pageWarningSynonyms += '</div>';
4445

@@ -69,7 +70,7 @@ require(
6970
const searchableSelect = $('select[name="groups[instant_facets][fields][facets][value][' + rowId + '][searchable]"]');
7071

7172
searchableSelect.on('change', function(){
72-
configQrFromSearchableSelect($(this));
73+
configQrFromSearchableSelect($(this));
7374
});
7475

7576
configQrFromSearchableSelect(searchableSelect);
@@ -93,4 +94,4 @@ require(
9394
}
9495

9596
}
96-
);
97+
);

0 commit comments

Comments
 (0)