MAGE-1044 Localize setup/teardown for virtual replica test case

Author: cammonro

Test/Integration/Product/ReplicaIndexingTest.php

@@ -17,17 +17,13 @@ class ReplicaIndexingTest extends IndexingTestCase
 
     protected ?string $indexSuffix = null;
 
-    protected ?array $ogSortingState = null;
-
     public function setUp(): void
     {
         parent::setUp();
         $this->productIndexer = $this->objectManager->get(ProductIndexer::class);
         $this->replicaManager = $this->objectManager->get(ReplicaManagerInterface::class);
         $this->indicesConfigurator = $this->objectManager->get(IndicesConfigurator::class);
         $this->indexSuffix = 'products';
-
-        $this->ogSortingState = $this->configHelper->getSorting();
     }
 
     protected function getIndexName(string $storeIndexPart): string
@@ -40,28 +36,6 @@ public function processFullReindexProducts(): void
         $this->processFullReindex($this->productIndexer, $this->indexSuffix);
     }
 
-    protected function hasSortingAttribute($sortAttr, $sortDir): bool
-    {
-        $sorting = $this->configHelper->getSorting();
-        return (bool) array_filter(
-            $sorting,
-            function($sort) use ($sortAttr, $sortDir) {
-                return $sort['attribute'] == $sortAttr
-                    && $sort['sort'] == $sortDir;
-            }
-        );
-    }
-
-    protected function assertSortingAttribute($sortAttr, $sortDir): void
-    {
-        $this->assertTrue($this->hasSortingAttribute($sortAttr, $sortDir));
-    }
-
-    protected function assertNoSortingAttribute($sortAttr, $sortDir): void
-    {
-        $this->assertFalse($this->hasSortingAttribute($sortAttr, $sortDir));
-    }
-
     public function testReplicaLimits()
     {
         $this->assertEquals(20, $this->replicaManager->getMaxVirtualReplicasPerIndex());
@@ -101,13 +75,16 @@ public function testStandardReplicaConfig(): void
     }
 
     /**
+     * This test involves verifying modifications in the database
+     * so it must be responsible for its own set up and tear down
      * @magentoDbIsolation disabled
      * @group virtual
      */
     public function testVirtualReplicaConfig(): void
     {
         $indexName = $this->getIndexName('default_');
         $ogAlgoliaSettings = $this->algoliaHelper->getSettings($indexName);
+        $ogSortingState = $this->configHelper->getSorting();
 
         $this->assertFalse(array_key_exists('replicas', $ogAlgoliaSettings));
 
@@ -160,8 +137,8 @@ public function testVirtualReplicaConfig(): void
 
         // Restore prior state (for this test only)
         $this->algoliaHelper->setSettings($indexName, $ogAlgoliaSettings);
+        $this->configHelper->setSorting($ogSortingState);
         $this->setConfig('algoliasearch_instant/instant/is_instant_enabled', 0);
-
     }
 
     /**
@@ -190,8 +167,31 @@ function ($replica) use ($replicaIndexName) {
         );
     }
 
+    protected function hasSortingAttribute($sortAttr, $sortDir): bool
+    {
+        $sorting = $this->configHelper->getSorting();
+        return (bool) array_filter(
+            $sorting,
+            function($sort) use ($sortAttr, $sortDir) {
+                return $sort['attribute'] == $sortAttr
+                    && $sort['sort'] == $sortDir;
+            }
+        );
+    }
+
+    protected function assertSortingAttribute($sortAttr, $sortDir): void
+    {
+        $this->assertTrue($this->hasSortingAttribute($sortAttr, $sortDir));
+    }
+
+    protected function assertNoSortingAttribute($sortAttr, $sortDir): void
+    {
+        $this->assertFalse($this->hasSortingAttribute($sortAttr, $sortDir));
+    }
+
     public function tearDown(): void
     {
-        $this->configHelper->setSorting($this->ogSortingState);
+        parent::tearDown();
     }
+
 }