MAGE-848 Ensure comparisons against Algolia replica config are always checking the latest possible sorting index config in Magento

Author: cammonro

Service/Product/ReplicaManager.php

@@ -86,7 +86,9 @@ protected function hasReplicaConfigurationChanged(int $storeId): bool
             default:
                 $primaryIndexName = $this->indexNameFetcher->getProductIndexName($storeId);
                 $old = $this->getMagentoReplicaConfigurationFromAlgolia($primaryIndexName);
-                $new = $this->sortingTransformer->transformSortingIndicesToReplicaSetting($this->sortingTransformer->getSortingIndices($storeId));
+                $new = $this->sortingTransformer->transformSortingIndicesToReplicaSetting(
+                    $this->sortingTransformer->getSortingIndices($storeId, null, null, true)
+                );
                 sort($old);
                 sort($new);
                 return $old !== $new;

Service/Product/SortingTransformer.php

@@ -38,19 +38,25 @@ public function __construct(
      * @param ?int $storeId
      * @param ?int $currentCustomerGroupId
      * @param ?array $attrs - serialized array of sorting attributes to transform (defaults to saved sorting config)
+     * @param bool $clearCache - If set to true will update the cache
      * @return array of transformed sorting / replica objects
      * @throws LocalizedException
      * @throws NoSuchEntityException
      */
     public function getSortingIndices(
         ?int   $storeId = null,
         ?int   $currentCustomerGroupId = null,
-        ?array $attrs = null
+        ?array $attrs = null,
+        bool   $clearCache = false
     ): array
     {
         // Selectively cache this result - only cache manipulation of saved settings per store
         $useCache = is_null($currentCustomerGroupId) && is_null($attrs);
 
+        if ($clearCache) {
+            unset($this->_sortingIndices[$storeId]);
+        }
+
         if ($useCache
             && array_key_exists($storeId, $this->_sortingIndices)
             && is_array($this->_sortingIndices[$storeId])) {