Circle CI

Author: ratikant-singh

.circleci/config.yml

@@ -9,7 +9,7 @@ shared: &shared
         name: Override the Algolia extension with the cloned one
         command: |
           cd ~/magento_directory/vendor/algolia
-          # rm -rf algoliasearch-magento-2
+          rm -rf algoliasearch-magento-2
           cp -R ~/build_directory/algoliasearch-magento-2 ~/magento_directory/vendor/algolia
           cd ~/magento_directory
           composer dump-autoload
@@ -58,10 +58,15 @@ shared: &shared
           php -dmemory_limit=-1 ../../../vendor/bin/phpunit --debug ../../../vendor/algolia/algoliasearch-magento-2/Test
 
 jobs:
+  "magento-2.3":
+    <<: *shared
+    docker:
+      - image: algolia/magento2-circleci:v3-2.3.5-p2
+
   "magento-2.4":
     <<: *shared
     docker:
-      - image: algolia/magento2-circleci:2.4.4-php7.4-v1
+      - image: algolia/magento2-circleci:v3-2.4.0
 
   "quality-tools":
     docker:
@@ -105,5 +110,6 @@ workflows:
   version: 2
   build:
     jobs:
+      - "magento-2.3"
       - "magento-2.4"
       - "quality-tools"

Setup/Patch/Schema/ConfigPatch.php

@@ -257,15 +257,9 @@ class ConfigPatch implements SchemaPatchInterface
             ],
         ],
     ];
-    private IndexerInterfaceFactory $indexerFactory;
 
-    /**
-     * @param ConfigInterface $config
-     * @param ProductMetadataInterface $productMetadata
-     * @param ModuleDataSetupInterface $moduleDataSetup
-     * @param SubscriptionFactory $subscriptionFactory
-     * @param IndexerInterfaceFactory $indexerFactory
-     */
+    private $indexerFactory;
+
     public function __construct(
         ConfigInterface $config,
         ProductMetadataInterface $productMetadata,