Skip to content

Commit 697ce35

Browse files
authored
Refactor popular queries collection and mview class for additional sections (#1134)
1 parent 3fd75a5 commit 697ce35

File tree

3 files changed

+7
-21
lines changed

3 files changed

+7
-21
lines changed

Helper/Entity/SuggestionHelper.php

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -106,28 +106,20 @@ public function getPopularQueries($storeId)
106106
$collection->getSelect()->where(
107107
'num_results >= ' . $this->configHelper->getMinNumberOfResults() . '
108108
AND popularity >= ' . $this->configHelper->getMinPopularity() . '
109-
AND query_text != "__empty__"'
109+
AND query_text != "__empty__" AND CHAR_LENGTH(query_text) >= 3'
110110
);
111-
$collection->getSelect()->limit(12);
112-
$collection->setOrder('popularity', 'DESC');
113-
$collection->setOrder('num_results', 'DESC');
114-
$collection->setOrder('updated_at', 'ASC');
115111

116112
if ($storeId) {
117113
$collection->getSelect()->where('store_id = ?', (int) $storeId);
118114
}
119115

120-
$collection->load();
121-
122-
$suggestions = [];
116+
$collection->setOrder('popularity', 'DESC');
117+
$collection->setOrder('num_results', 'DESC');
118+
$collection->setOrder('updated_at', 'ASC');
123119

124-
foreach ($collection as $suggestion) {
125-
if (mb_strlen($suggestion['query_text']) >= 3) {
126-
$suggestions[] = $suggestion['query_text'];
127-
}
128-
}
120+
$collection->getSelect()->limit(10);
129121

130-
$queries = array_slice($suggestions, 0, 9);
122+
$queries = $collection->getColumnValues('query_text');
131123

132124
$this->cache->save($this->serializer->serialize($queries), $this->popularQueriesCacheId, [], 24*3600);
133125

etc/csp_whitelist.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,5 @@
1313
<value id="algolia" type="host">*.algolia.com</value>
1414
</values>
1515
</policy>
16-
<policy id="connect-src">
17-
<values>
18-
<value id="algolia-api" type="host">*.algolia.net</value>
19-
<value id="algolia" type="host">*.algolia.com</value>
20-
</values>
21-
</policy>
2216
</policies>
2317
</csp_whitelist>

etc/mview.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<table name="cms_page" entity_column="page_id" />
88
</subscriptions>
99
</view>
10-
<view id="algolia_additional_sections" class="Algolia\AlgoliaSearch\Model\Indexer\Page" group="indexer">
10+
<view id="algolia_additional_sections" class="Algolia\AlgoliaSearch\Model\Indexer\AdditionalSection" group="indexer">
1111
</view>
1212
<view id="algolia_queue_runner" class="Algolia\AlgoliaSearch\Model\Indexer\QueueRunner" group="indexer">
1313
</view>

0 commit comments

Comments
 (0)