MAGE-1281 Change conditional logic per review

Author: cammonro

Service/ReplicaSettingsHandler.php

@@ -36,33 +36,34 @@ public function setSettings(
         string $mergeSettingsFrom = ''
     ): void
     {
-        if ($this->config->shouldForwardPrimaryIndexSettingsToReplicas($indexOptions->getStoreId())) {
-            [$forward, $noForward] = $this->splitSettings($indexSettings);
-            if ($forward) {
-                $this->connector->setSettings(
-                    $indexOptions,
-                    $forward,
-                    true,
-                    false
-                );
-            }
-            if ($noForward) {
-                $this->connector->setSettings(
-                    $indexOptions,
-                    $noForward,
-                    false,
-                    true,
-                    $mergeSettingsFrom
-                );
-            }
-        } else {
+        if (!$this->config->shouldForwardPrimaryIndexSettingsToReplicas($indexOptions->getStoreId())) {
             $this->connector->setSettings(
                 $indexOptions,
                 $indexSettings,
                 false,
                 true,
                 $mergeSettingsFrom
             );
+            return;
+        }
+
+        [$forward, $noForward] = $this->splitSettings($indexSettings);
+        if ($forward) {
+            $this->connector->setSettings(
+                $indexOptions,
+                $forward,
+                true,
+                false
+            );
+        }
+        if ($noForward) {
+            $this->connector->setSettings(
+                $indexOptions,
+                $noForward,
+                false,
+                true,
+                $mergeSettingsFrom
+            );
         }
     }