MAGE-827 Add types for landing page validation on PHP connector v4

Author: cammonro

Controller/Adminhtml/Landingpage/Delete.php

@@ -2,6 +2,7 @@
 
 namespace Algolia\AlgoliaSearch\Controller\Adminhtml\Landingpage;
 
+use Algolia\AlgoliaSearch\Model\LandingPage;
 use Magento\Framework\Controller\ResultFactory;
 
 class Delete extends AbstractAction
@@ -15,7 +16,7 @@ public function execute()
         $landingPageId = $this->getRequest()->getParam('id');
         if ($landingPageId) {
             try {
-                /** @var \Algolia\AlgoliaSearch\Model\LandingPage $landingPage */
+                /** @var LandingPage $landingPage */
                 $landingPage = $this->landingPageFactory->create();
                 $landingPage->getResource()->load($landingPage, $landingPageId);
                 $landingPage->getResource()->delete($landingPage);
@@ -35,7 +36,12 @@ public function execute()
         return $resultRedirect->setPath('*/*/');
     }
 
-    private function deleteQueryRules($landingPage)
+    /**
+     * @param LandingPage $landingPage
+     * @return void
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    private function deleteQueryRules(LandingPage $landingPage): void
     {
         $stores = [];
         if ($landingPage->getStoreId() == 0) {

Controller/Adminhtml/Landingpage/Duplicate.php

@@ -2,6 +2,8 @@
 
 namespace Algolia\AlgoliaSearch\Controller\Adminhtml\Landingpage;
 
+use Algolia\AlgoliaSearch\Exceptions\AlgoliaException;
+use Algolia\AlgoliaSearch\Model\LandingPage;
 use Magento\Framework\Controller\ResultFactory;
 use Magento\Framework\Exception\LocalizedException;
 
@@ -20,7 +22,7 @@ public function execute()
             return $resultRedirect->setPath('*/*/');
         }
 
-        /** @var \Algolia\AlgoliaSearch\Model\LandingPage $landingPage */
+        /** @var LandingPage $landingPage */
         $landingPage = $this->landingPageFactory->create();
         $landingPage->getResource()->load($landingPage, $landingPageId);
 
@@ -53,9 +55,13 @@ public function execute()
         return $resultRedirect->setPath('*/*/');
     }
 
-    private function duplicateLandingPage($landingPage)
+    /**
+     * @param LandingPage $landingPage
+     * @return LandingPage
+     */
+    private function duplicateLandingPage(LandingPage $landingPage): LandingPage
     {
-        /** @var \Algolia\AlgoliaSearch\Model\LandingPage $newLandingPage */
+        /** @var LandingPage $newLandingPage */
         $newLandingPage = $this->landingPageFactory->create();
         $newLandingPage->setData($landingPage->getData());
         $newLandingPage->setId(null);
@@ -65,7 +71,13 @@ private function duplicateLandingPage($landingPage)
         return $newLandingPage;
     }
 
-    private function copyQueryRules($landingPageFromId, $landingPageToId)
+    /**
+     * @param int $landingPageFromId
+     * @param int $landingPageToId
+     * @return void
+     * @throws AlgoliaException|\Magento\Framework\Exception\NoSuchEntityException
+     */
+    private function copyQueryRules(int $landingPageFromId, int $landingPageToId): void
     {
         $stores = [];
         if ($landingPageFromId) {

Controller/Adminhtml/Landingpage/Save.php

@@ -154,11 +154,12 @@ public function execute()
     }
 
     /**
-     * @param $landingPageId
-     * @param $data
+     * @param int $landingPageId
+     * @param array<string, mixed> $data
      * @return void
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
      */
-    protected function manageQueryRules($landingPageId, $data)
+    protected function manageQueryRules(int $landingPageId, array $data): void
     {
         $positions = json_decode($data['algolia_merchandising_positions'], true);
         $stores = [];

Helper/MerchandisingHelper.php

@@ -109,7 +109,11 @@ public function deleteQueryRule(int $storeId, int $entityId, string $entityType)
         $this->algoliaHelper->deleteRule($productsIndexName, $ruleId);
     }
 
-    private function transformPositions($positions)
+    /**
+     * @param array $positions
+     * @return array
+     */
+    private function transformPositions(array $positions): array
     {
         $transformedPositions = [];
 
@@ -125,13 +129,13 @@ private function transformPositions($positions)
 
     /**
      * @param int $storeId
-     * @param $entityIdFrom
-     * @param $entityIdTo
-     * @param $entityType
-     *
+     * @param int $entityIdFrom
+     * @param int $entityIdTo
+     * @param string $entityType
+     * @return void
      * @throws AlgoliaException|\Magento\Framework\Exception\NoSuchEntityException
      */
-    public function copyQueryRules(int $storeId, $entityIdFrom, $entityIdTo, $entityType): void
+    public function copyQueryRules(int $storeId, int $entityIdFrom, int $entityIdTo, string $entityType): void
     {
         $productsIndexName = $this->coreHelper->getIndexName($this->productHelper->getIndexNameSuffix(), $storeId);
         $client = $this->algoliaHelper->getClient();