Skip to content

Commit 6d54976

Browse files
committed
MAGE-1379 - phpcs fixes
1 parent ab56b4d commit 6d54976

File tree

5 files changed

+23
-8
lines changed

5 files changed

+23
-8
lines changed

view/adminhtml/templates/support/overview.phtml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<?php
22

33
/** @var \Magento\Backend\Block\Template $block */
4-
4+
/** @var \Magento\Framework\Escaper $escaper */
5+
/** TODO:Reevaluate PHPCS ignores and enables/disables */
56
/** @var \Algolia\AlgoliaSearch\ViewModel\Adminhtml\Support\Overview $view */
67
$view = $block->getViewModel();
78

@@ -31,10 +32,11 @@ $videoFeatures = $block->getViewFileUrl('Algolia_AlgoliaSearch::images/video-fea
3132
<div id="algolia_support_tab_content">
3233

3334
<div class="algolia_support_panel" id="algolia-documentation-panel">
34-
35+
<!-- phpcs:disable Magento2.Security.EscapeOutput.OutputNotEscaped -->
3536
<script>
3637
const noResultsIllustration = "<?php echo $noResultsIllustration; ?>"
3738
</script>
39+
<!-- phpcs:enable Magento2.Security.EscapeOutput.OutputNotEscaped -->
3840

3941
<div class="search-box-wrapper">
4042
<input type="text" name="q" id="search_box" />
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
<?php
2+
/** @var \Magento\Framework\Escaper $escaper */
3+
/** TODO:Reevaluate PHPCS ignores and enables/disables */
24
/** @var \Algolia\AlgoliaSearch\Block\Checkout\Conversion $block */
35
$orderItemsJson = $block->getOrderItemsConversionJson();
46
?>
5-
7+
<!-- phpcs:disable Magento2.Security.EscapeOutput.OutputNotEscaped -->
68
<script type="text/javascript">
7-
var algoliaOrderConversionJson = <?php echo $orderItemsJson ?>;
8-
</script>
9+
var algoliaOrderConversionJson = <?= $orderItemsJson ?>;
10+
</script>
11+
<!-- phpcs:enable Magento2.Security.EscapeOutput.OutputNotEscaped -->

view/frontend/templates/layer/filter/slider.phtml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<?php
2+
/** @var \Magento\Framework\Escaper $escaper */
3+
/** TODO:Reevaluate PHPCS ignores and enables/disables */
4+
?>
15
<div class="algolia-range-slider" data-role="<?php /* @noEscape */ echo $block->getDataRole(); ?>">
26
<div data-role="from-label"></div>
37
<div data-role="to-label"></div>
@@ -10,7 +14,8 @@
1014
</div>
1115
</div>
1216
</div>
13-
17+
<!-- phpcs:disable Magento2.Security.EscapeOutput.OutputNotEscaped -->
1418
<script type="text/x-magento-init">
15-
{ "[data-role=<?php /* @noEscape */ echo $block->getDataRole(); ?>]" : { "rangeSlider" : <?php echo /* @noEscape */ $block->getJsonConfig(); ?> } }
19+
{ "[data-role=<?php /* @noEscape */ echo $block->getDataRole(); ?>]" : { "rangeSlider" : <?= /* @noEscape */ $block->getJsonConfig(); ?> } }
1620
</script>
21+
<!-- phpcs:enable Magento2.Security.EscapeOutput.OutputNotEscaped -->

view/frontend/templates/recommend/cart/recommend_items.phtml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22
/** @var \Algolia\AlgoliaSearch\ViewModel\Recommend\Cart $block */
3+
/** @var \Magento\Framework\Escaper $escaper */
4+
/** TODO:Reevaluate PHPCS ignores and enables/disables */
35
$viewModel = $block->getViewModel();
46
$recommendConfig = $viewModel->getAlgoliaRecommendConfiguration();
57
if (!empty($recommendConfig['enabledRelatedInCart']) || !empty($recommendConfig['enabledFBTInCart']) || !empty($recommendConfig['isTrendItemsEnabledInCartPage'])):
@@ -11,6 +13,7 @@ if (!empty($recommendConfig['enabledRelatedInCart']) || !empty($recommendConfig[
1113
<div id="trendItems" class="trendsItem recommend-component"></div>
1214
<div id="lookingSimilar" class="lookingSimilar recommend-component"></div>
1315
</div>
16+
<!-- phpcs:disable Magento2.Security.EscapeOutput.OutputNotEscaped -->
1417
<script type="text/x-magento-init">
1518
{
1619
"*": {
@@ -20,6 +23,7 @@ if (!empty($recommendConfig['enabledRelatedInCart']) || !empty($recommendConfig[
2023
}
2124
}
2225
</script>
26+
<!-- phpcs:enable Magento2.Security.EscapeOutput.OutputNotEscaped -->
2327
<script type="text/x-magento-init">
2428
{
2529
"[data-role=tocart-form]": {

view/frontend/templates/recommend/products.phtml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ use Magento\Framework\View\Element\Template;
55
/**
66
* @var ProductView $viewModel
77
* @var Template $block
8+
* @var \Magento\Framework\Escaper $escaper
89
*/
910
$viewModel = $block->getViewModel();
1011
$recommendConfig = $viewModel->getAlgoliaRecommendConfiguration();
@@ -24,7 +25,7 @@ if (!empty($recommendConfig['enabledFBT'])
2425
{
2526
"*": {
2627
"Algolia_AlgoliaSearch/js/recommend" : {
27-
"objectIDs" : ["<?= $product->getId() ?>"]
28+
"objectIDs" : ["<?= $escaper->escapeJs($product->getId()) ?>"]
2829
}
2930
}
3031
}

0 commit comments

Comments
 (0)